237 lines
8.8 KiB
Diff
237 lines
8.8 KiB
Diff
|
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
||
|
From: Jonas Karlman <jonas@kwiboo.se>
|
||
|
Date: Mon, 6 Jul 2020 22:30:13 +0000
|
||
|
Subject: [PATCH] drm: drm_fourcc: add NV20 and NV30 YUV formats
|
||
|
|
||
|
DRM_FORMAT_NV20 and DRM_FORMAT_NV30 formats is the 2x1 and non-subsampled
|
||
|
variant of NV15, a 10-bit 2-plane YUV format that has no padding between
|
||
|
components. Instead, luminance and chrominance samples are grouped into 4s
|
||
|
so that each group is packed into an integer number of bytes:
|
||
|
|
||
|
YYYY = UVUV = 4 * 10 bits = 40 bits = 5 bytes
|
||
|
|
||
|
The '20' and '30' suffix refers to the optimum effective bits per pixel
|
||
|
which is achieved when the total number of luminance samples is a multiple
|
||
|
of 4.
|
||
|
|
||
|
V2: Added NV30 format
|
||
|
|
||
|
Signed-off-by: Jonas Karlman <jonas@kwiboo.se>
|
||
|
Reviewed-by: Sandy Huang <hjc@rock-chips.com>
|
||
|
---
|
||
|
drivers/gpu/drm/drm_fourcc.c | 8 ++++++++
|
||
|
include/uapi/drm/drm_fourcc.h | 2 ++
|
||
|
2 files changed, 10 insertions(+)
|
||
|
|
||
|
diff --git a/drivers/gpu/drm/drm_fourcc.c b/drivers/gpu/drm/drm_fourcc.c
|
||
|
index 07741b678798..5ec38456dc5d 100644
|
||
|
--- a/drivers/gpu/drm/drm_fourcc.c
|
||
|
+++ b/drivers/gpu/drm/drm_fourcc.c
|
||
|
@@ -261,6 +261,14 @@ const struct drm_format_info *__drm_format_info(u32 format)
|
||
|
.num_planes = 2, .char_per_block = { 5, 5, 0 },
|
||
|
.block_w = { 4, 2, 0 }, .block_h = { 1, 1, 0 }, .hsub = 2,
|
||
|
.vsub = 2, .is_yuv = true },
|
||
|
+ { .format = DRM_FORMAT_NV20, .depth = 0,
|
||
|
+ .num_planes = 2, .char_per_block = { 5, 5, 0 },
|
||
|
+ .block_w = { 4, 2, 0 }, .block_h = { 1, 1, 0 }, .hsub = 2,
|
||
|
+ .vsub = 1, .is_yuv = true },
|
||
|
+ { .format = DRM_FORMAT_NV30, .depth = 0,
|
||
|
+ .num_planes = 2, .char_per_block = { 5, 5, 0 },
|
||
|
+ .block_w = { 4, 2, 0 }, .block_h = { 1, 1, 0 }, .hsub = 1,
|
||
|
+ .vsub = 1, .is_yuv = true },
|
||
|
{ .format = DRM_FORMAT_Q410, .depth = 0,
|
||
|
.num_planes = 3, .char_per_block = { 2, 2, 2 },
|
||
|
.block_w = { 1, 1, 1 }, .block_h = { 1, 1, 1 }, .hsub = 0,
|
||
|
diff --git a/include/uapi/drm/drm_fourcc.h b/include/uapi/drm/drm_fourcc.h
|
||
|
index 0206f812c569..fa49ee98f275 100644
|
||
|
--- a/include/uapi/drm/drm_fourcc.h
|
||
|
+++ b/include/uapi/drm/drm_fourcc.h
|
||
|
@@ -285,6 +285,8 @@ extern "C" {
|
||
|
* index 1 = Cr:Cb plane, [39:0] Cr1:Cb1:Cr0:Cb0 little endian
|
||
|
*/
|
||
|
#define DRM_FORMAT_NV15 fourcc_code('N', 'V', '1', '5') /* 2x2 subsampled Cr:Cb plane */
|
||
|
+#define DRM_FORMAT_NV20 fourcc_code('N', 'V', '2', '0') /* 2x1 subsampled Cr:Cb plane */
|
||
|
+#define DRM_FORMAT_NV30 fourcc_code('N', 'V', '3', '0') /* non-subsampled Cr:Cb plane */
|
||
|
|
||
|
/*
|
||
|
* 2 plane YCbCr MSB aligned
|
||
|
|
||
|
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
||
|
From: Jonas Karlman <jonas@kwiboo.se>
|
||
|
Date: Mon, 6 Jul 2020 22:30:13 +0000
|
||
|
Subject: [PATCH] drm: rockchip: add NV15, NV20 and NV30 support
|
||
|
|
||
|
Add support for displaying 10-bit 4:2:0 and 4:2:2 formats produced by the
|
||
|
Rockchip Video Decoder on RK322X, RK3288, RK3328, RK3368 and RK3399.
|
||
|
Also add support for 10-bit 4:4:4 format while at it.
|
||
|
|
||
|
V2: Added NV30 support
|
||
|
|
||
|
Signed-off-by: Jonas Karlman <jonas@kwiboo.se>
|
||
|
Reviewed-by: Sandy Huang <hjc@rock-chips.com>
|
||
|
---
|
||
|
drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 29 +++++++++++++++++--
|
||
|
drivers/gpu/drm/rockchip/rockchip_drm_vop.h | 1 +
|
||
|
drivers/gpu/drm/rockchip/rockchip_vop_reg.c | 32 +++++++++++++++++----
|
||
|
3 files changed, 54 insertions(+), 8 deletions(-)
|
||
|
|
||
|
diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
|
||
|
index d32117633efe..9e71263ac770 100644
|
||
|
--- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
|
||
|
+++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
|
||
|
@@ -280,6 +280,18 @@ static bool has_uv_swapped(uint32_t format)
|
||
|
}
|
||
|
}
|
||
|
|
||
|
+static bool is_fmt_10(uint32_t format)
|
||
|
+{
|
||
|
+ switch (format) {
|
||
|
+ case DRM_FORMAT_NV15:
|
||
|
+ case DRM_FORMAT_NV20:
|
||
|
+ case DRM_FORMAT_NV30:
|
||
|
+ return true;
|
||
|
+ default:
|
||
|
+ return false;
|
||
|
+ }
|
||
|
+}
|
||
|
+
|
||
|
static enum vop_data_format vop_convert_format(uint32_t format)
|
||
|
{
|
||
|
switch (format) {
|
||
|
@@ -295,12 +307,15 @@ static enum vop_data_format vop_convert_format(uint32_t format)
|
||
|
case DRM_FORMAT_BGR565:
|
||
|
return VOP_FMT_RGB565;
|
||
|
case DRM_FORMAT_NV12:
|
||
|
+ case DRM_FORMAT_NV15:
|
||
|
case DRM_FORMAT_NV21:
|
||
|
return VOP_FMT_YUV420SP;
|
||
|
case DRM_FORMAT_NV16:
|
||
|
+ case DRM_FORMAT_NV20:
|
||
|
case DRM_FORMAT_NV61:
|
||
|
return VOP_FMT_YUV422SP;
|
||
|
case DRM_FORMAT_NV24:
|
||
|
+ case DRM_FORMAT_NV30:
|
||
|
case DRM_FORMAT_NV42:
|
||
|
return VOP_FMT_YUV444SP;
|
||
|
default:
|
||
|
@@ -954,7 +969,12 @@ static void vop_plane_atomic_update(struct drm_plane *plane,
|
||
|
dsp_sty = dest->y1 + crtc->mode.vtotal - crtc->mode.vsync_start;
|
||
|
dsp_st = dsp_sty << 16 | (dsp_stx & 0xffff);
|
||
|
|
||
|
- offset = (src->x1 >> 16) * fb->format->cpp[0];
|
||
|
+ if (fb->format->block_w[0])
|
||
|
+ offset = (src->x1 >> 16) * fb->format->char_per_block[0] /
|
||
|
+ fb->format->block_w[0];
|
||
|
+ else
|
||
|
+ offset = (src->x1 >> 16) * fb->format->cpp[0];
|
||
|
+
|
||
|
offset += (src->y1 >> 16) * fb->pitches[0];
|
||
|
dma_addr = rk_obj->dma_addr + offset + fb->offsets[0];
|
||
|
|
||
|
@@ -980,6 +1000,7 @@ static void vop_plane_atomic_update(struct drm_plane *plane,
|
||
|
}
|
||
|
|
||
|
VOP_WIN_SET(vop, win, format, format);
|
||
|
+ VOP_WIN_SET(vop, win, fmt_10, is_fmt_10(fb->format->format));
|
||
|
VOP_WIN_SET(vop, win, yrgb_vir, DIV_ROUND_UP(fb->pitches[0], 4));
|
||
|
VOP_WIN_SET(vop, win, yrgb_mst, dma_addr);
|
||
|
VOP_WIN_YUV2YUV_SET(vop, win_yuv2yuv, y2r_en, is_yuv);
|
||
|
@@ -996,7 +1017,11 @@ static void vop_plane_atomic_update(struct drm_plane *plane,
|
||
|
uv_obj = fb->obj[1];
|
||
|
rk_uv_obj = to_rockchip_obj(uv_obj);
|
||
|
|
||
|
- offset = (src->x1 >> 16) * bpp / hsub;
|
||
|
+ if (fb->format->block_w[1])
|
||
|
+ offset = (src->x1 >> 16) * bpp /
|
||
|
+ fb->format->block_w[1] / hsub;
|
||
|
+ else
|
||
|
+ offset = (src->x1 >> 16) * bpp / hsub;
|
||
|
offset += (src->y1 >> 16) * fb->pitches[1] / vsub;
|
||
|
|
||
|
dma_addr = rk_uv_obj->dma_addr + offset + fb->offsets[1];
|
||
|
diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.h b/drivers/gpu/drm/rockchip/rockchip_drm_vop.h
|
||
|
index 8502849833d9..b6eea31109d5 100644
|
||
|
--- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.h
|
||
|
+++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.h
|
||
|
@@ -181,6 +181,7 @@ struct vop_win_phy {
|
||
|
struct vop_reg enable;
|
||
|
struct vop_reg gate;
|
||
|
struct vop_reg format;
|
||
|
+ struct vop_reg fmt_10;
|
||
|
struct vop_reg rb_swap;
|
||
|
struct vop_reg uv_swap;
|
||
|
struct vop_reg act_info;
|
||
|
diff --git a/drivers/gpu/drm/rockchip/rockchip_vop_reg.c b/drivers/gpu/drm/rockchip/rockchip_vop_reg.c
|
||
|
index 014f99e8928e..16e6aa01e400 100644
|
||
|
--- a/drivers/gpu/drm/rockchip/rockchip_vop_reg.c
|
||
|
+++ b/drivers/gpu/drm/rockchip/rockchip_vop_reg.c
|
||
|
@@ -53,6 +53,23 @@ static const uint32_t formats_win_full[] = {
|
||
|
DRM_FORMAT_NV42,
|
||
|
};
|
||
|
|
||
|
+static const uint32_t formats_win_full_10[] = {
|
||
|
+ DRM_FORMAT_XRGB8888,
|
||
|
+ DRM_FORMAT_ARGB8888,
|
||
|
+ DRM_FORMAT_XBGR8888,
|
||
|
+ DRM_FORMAT_ABGR8888,
|
||
|
+ DRM_FORMAT_RGB888,
|
||
|
+ DRM_FORMAT_BGR888,
|
||
|
+ DRM_FORMAT_RGB565,
|
||
|
+ DRM_FORMAT_BGR565,
|
||
|
+ DRM_FORMAT_NV12,
|
||
|
+ DRM_FORMAT_NV16,
|
||
|
+ DRM_FORMAT_NV24,
|
||
|
+ DRM_FORMAT_NV15,
|
||
|
+ DRM_FORMAT_NV20,
|
||
|
+ DRM_FORMAT_NV30,
|
||
|
+};
|
||
|
+
|
||
|
static const uint64_t format_modifiers_win_full[] = {
|
||
|
DRM_FORMAT_MOD_LINEAR,
|
||
|
DRM_FORMAT_MOD_INVALID,
|
||
|
@@ -621,11 +638,12 @@ static const struct vop_scl_regs rk3288_win_full_scl = {
|
||
|
|
||
|
static const struct vop_win_phy rk3288_win01_data = {
|
||
|
.scl = &rk3288_win_full_scl,
|
||
|
- .data_formats = formats_win_full,
|
||
|
- .nformats = ARRAY_SIZE(formats_win_full),
|
||
|
+ .data_formats = formats_win_full_10,
|
||
|
+ .nformats = ARRAY_SIZE(formats_win_full_10),
|
||
|
.format_modifiers = format_modifiers_win_full,
|
||
|
.enable = VOP_REG(RK3288_WIN0_CTRL0, 0x1, 0),
|
||
|
.format = VOP_REG(RK3288_WIN0_CTRL0, 0x7, 1),
|
||
|
+ .fmt_10 = VOP_REG(RK3288_WIN0_CTRL0, 0x1, 4),
|
||
|
.rb_swap = VOP_REG(RK3288_WIN0_CTRL0, 0x1, 12),
|
||
|
.uv_swap = VOP_REG(RK3288_WIN0_CTRL0, 0x1, 15),
|
||
|
.act_info = VOP_REG(RK3288_WIN0_ACT_INFO, 0x1fff1fff, 0),
|
||
|
@@ -756,11 +774,12 @@ static const struct vop_intr rk3368_vop_intr = {
|
||
|
|
||
|
static const struct vop_win_phy rk3368_win01_data = {
|
||
|
.scl = &rk3288_win_full_scl,
|
||
|
- .data_formats = formats_win_full,
|
||
|
- .nformats = ARRAY_SIZE(formats_win_full),
|
||
|
+ .data_formats = formats_win_full_10,
|
||
|
+ .nformats = ARRAY_SIZE(formats_win_full_10),
|
||
|
.format_modifiers = format_modifiers_win_full,
|
||
|
.enable = VOP_REG(RK3368_WIN0_CTRL0, 0x1, 0),
|
||
|
.format = VOP_REG(RK3368_WIN0_CTRL0, 0x7, 1),
|
||
|
+ .fmt_10 = VOP_REG(RK3368_WIN0_CTRL0, 0x1, 4),
|
||
|
.rb_swap = VOP_REG(RK3368_WIN0_CTRL0, 0x1, 12),
|
||
|
.uv_swap = VOP_REG(RK3368_WIN0_CTRL0, 0x1, 15),
|
||
|
.x_mir_en = VOP_REG(RK3368_WIN0_CTRL0, 0x1, 21),
|
||
|
@@ -924,11 +943,12 @@ static const struct vop_win_yuv2yuv_data rk3399_vop_big_win_yuv2yuv_data[] = {
|
||
|
|
||
|
static const struct vop_win_phy rk3399_win01_data = {
|
||
|
.scl = &rk3288_win_full_scl,
|
||
|
- .data_formats = formats_win_full,
|
||
|
- .nformats = ARRAY_SIZE(formats_win_full),
|
||
|
+ .data_formats = formats_win_full_10,
|
||
|
+ .nformats = ARRAY_SIZE(formats_win_full_10),
|
||
|
.format_modifiers = format_modifiers_win_full_afbc,
|
||
|
.enable = VOP_REG(RK3288_WIN0_CTRL0, 0x1, 0),
|
||
|
.format = VOP_REG(RK3288_WIN0_CTRL0, 0x7, 1),
|
||
|
+ .fmt_10 = VOP_REG(RK3288_WIN0_CTRL0, 0x1, 4),
|
||
|
.rb_swap = VOP_REG(RK3288_WIN0_CTRL0, 0x1, 12),
|
||
|
.uv_swap = VOP_REG(RK3288_WIN0_CTRL0, 0x1, 15),
|
||
|
.x_mir_en = VOP_REG(RK3288_WIN0_CTRL0, 0x1, 21),
|