34 lines
1.0 KiB
Diff
34 lines
1.0 KiB
Diff
|
From 7f19b7e6b44bb1507c96cde5d039719bfb7ac5ae Mon Sep 17 00:00:00 2001
|
||
|
|
From: Samuel Holland <samuel@sholland.org>
|
||
|
|
Date: Mon, 30 Dec 2019 21:56:59 -0600
|
||
|
|
Subject: [PATCH 150/351] bus: sunxi-rsb: Always check register address
|
||
|
|
validity
|
||
|
|
|
||
|
|
The register address was already validated for read operations before
|
||
|
|
being truncated to a u8. Write operations have the same set of possible
|
||
|
|
addresses, and the address is being truncated from u32 to u8 here as
|
||
|
|
well, so the same check is needed.
|
||
|
|
|
||
|
|
Signed-off-by: Samuel Holland <samuel@sholland.org>
|
||
|
|
---
|
||
|
|
drivers/bus/sunxi-rsb.c | 3 +++
|
||
|
|
1 file changed, 3 insertions(+)
|
||
|
|
|
||
|
|
diff --git a/drivers/bus/sunxi-rsb.c b/drivers/bus/sunxi-rsb.c
|
||
|
|
index 1bb00a959c67..5cb4c92ec708 100644
|
||
|
|
--- a/drivers/bus/sunxi-rsb.c
|
||
|
|
+++ b/drivers/bus/sunxi-rsb.c
|
||
|
|
@@ -414,6 +414,9 @@ static int regmap_sunxi_rsb_reg_write(void *context, unsigned int reg,
|
||
|
|
struct sunxi_rsb_ctx *ctx = context;
|
||
|
|
struct sunxi_rsb_device *rdev = ctx->rdev;
|
||
|
|
|
||
|
|
+ if (reg > 0xff)
|
||
|
|
+ return -EINVAL;
|
||
|
|
+
|
||
|
|
return sunxi_rsb_write(rdev->rsb, rdev->rtaddr, reg, &val, ctx->size);
|
||
|
|
}
|
||
|
|
|
||
|
|
--
|
||
|
|
2.34.0
|
||
|
|
|