197 lines
7.1 KiB
Diff
197 lines
7.1 KiB
Diff
|
From 6ea4b200f29c9397482b43d5ac14bd2d1ddade53 Mon Sep 17 00:00:00 2001
|
||
|
From: Russell King <rmk+kernel@arm.linux.org.uk>
|
||
|
Date: Tue, 29 Nov 2016 10:13:46 +0000
|
||
|
Subject: mvebu/clearfog pcie updates
|
||
|
|
||
|
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
|
||
|
---
|
||
|
drivers/pci/controller/pci-mvebu.c | 76 ++++++++++++++++++++++++++++++++++++++
|
||
|
drivers/pci/pci-bridge-emul.c | 2 +
|
||
|
drivers/pci/pcie/aspm.c | 6 +++
|
||
|
drivers/pci/pcie/portdrv.c | 2 +
|
||
|
4 files changed, 86 insertions(+)
|
||
|
|
||
|
diff --git a/drivers/pci/controller/pci-mvebu.c b/drivers/pci/controller/pci-mvebu.c
|
||
|
index 1dc209f6f53a..bc66f82b8616 100644
|
||
|
--- a/drivers/pci/controller/pci-mvebu.c
|
||
|
+++ b/drivers/pci/controller/pci-mvebu.c
|
||
|
@@ -60,6 +60,12 @@
|
||
|
#define PCIE_INT_INTX(i) BIT(24+i)
|
||
|
#define PCIE_INT_PM_PME BIT(28)
|
||
|
#define PCIE_INT_ALL_MASK GENMASK(31, 0)
|
||
|
+#define PCIE_MASK_ERR_COR BIT(18)
|
||
|
+#define PCIE_MASK_ERR_NONFATAL BIT(17)
|
||
|
+#define PCIE_MASK_ERR_FATAL BIT(16)
|
||
|
+#define PCIE_MASK_FERR_DET BIT(10)
|
||
|
+#define PCIE_MASK_NFERR_DET BIT(9)
|
||
|
+#define PCIE_MASK_CORERR_DET BIT(8)
|
||
|
#define PCIE_CTRL_OFF 0x1a00
|
||
|
#define PCIE_CTRL_X1_MODE 0x0001
|
||
|
#define PCIE_CTRL_RC_MODE BIT(1)
|
||
|
@@ -619,6 +625,54 @@ mvebu_pci_bridge_emul_base_conf_read(struct pci_bridge_emul *bridge,
|
||
|
return PCI_BRIDGE_EMUL_HANDLED;
|
||
|
}
|
||
|
|
||
|
+static void mvebu_pcie_handle_irq_change(struct mvebu_pcie_port *port)
|
||
|
+{
|
||
|
+ u32 reg, old;
|
||
|
+ u16 devctl, rtctl;
|
||
|
+
|
||
|
+ /*
|
||
|
+ * Errors from downstream devices:
|
||
|
+ * bridge control register SERR: enables reception of errors
|
||
|
+ * Errors from this device, or received errors:
|
||
|
+ * command SERR: enables ERR_NONFATAL and ERR_FATAL messages
|
||
|
+ * => when enabled, these conditions also flag SERR in status register
|
||
|
+ * devctl CERE: enables ERR_CORR messages
|
||
|
+ * devctl NFERE: enables ERR_NONFATAL messages
|
||
|
+ * devctl FERE: enables ERR_FATAL messages
|
||
|
+ * Enabled messages then have three paths:
|
||
|
+ * 1. rtctl: enables system error indication
|
||
|
+ * 2. root error status register updated
|
||
|
+ * 3. root error command register: forwarding via MSI
|
||
|
+ */
|
||
|
+ old = mvebu_readl(port, PCIE_INT_UNMASK_OFF);
|
||
|
+ reg = old & ~(PCIE_INT_PM_PME | PCIE_MASK_FERR_DET |
|
||
|
+ PCIE_MASK_NFERR_DET | PCIE_MASK_CORERR_DET |
|
||
|
+ PCIE_MASK_ERR_COR | PCIE_MASK_ERR_NONFATAL |
|
||
|
+ PCIE_MASK_ERR_FATAL);
|
||
|
+
|
||
|
+ devctl = port->bridge.pcie_conf.devctl;
|
||
|
+ if (devctl & PCI_EXP_DEVCTL_FERE)
|
||
|
+ reg |= PCIE_MASK_FERR_DET | PCIE_MASK_ERR_FATAL;
|
||
|
+ if (devctl & PCI_EXP_DEVCTL_NFERE)
|
||
|
+ reg |= PCIE_MASK_NFERR_DET | PCIE_MASK_ERR_NONFATAL;
|
||
|
+ if (devctl & PCI_EXP_DEVCTL_CERE)
|
||
|
+ reg |= PCIE_MASK_CORERR_DET | PCIE_MASK_ERR_COR;
|
||
|
+ if (port->bridge.conf.command & PCI_COMMAND_SERR)
|
||
|
+ reg |= PCIE_MASK_FERR_DET | PCIE_MASK_NFERR_DET |
|
||
|
+ PCIE_MASK_ERR_FATAL | PCIE_MASK_ERR_NONFATAL;
|
||
|
+
|
||
|
+ if (!(port->bridge.conf.bridgectrl & PCI_BRIDGE_CTL_SERR))
|
||
|
+ reg &= ~(PCIE_MASK_ERR_COR | PCIE_MASK_ERR_NONFATAL |
|
||
|
+ PCIE_MASK_ERR_FATAL);
|
||
|
+
|
||
|
+ rtctl = port->bridge.pcie_conf.rootctl;
|
||
|
+ if (rtctl & PCI_EXP_RTCTL_PMEIE)
|
||
|
+ reg |= PCIE_INT_PM_PME;
|
||
|
+
|
||
|
+ if (old != reg)
|
||
|
+ mvebu_writel(port, reg, PCIE_INT_UNMASK_OFF);
|
||
|
+}
|
||
|
+
|
||
|
static pci_bridge_emul_read_status_t
|
||
|
mvebu_pci_bridge_emul_pcie_conf_read(struct pci_bridge_emul *bridge,
|
||
|
int reg, u32 *value)
|
||
|
@@ -735,6 +789,9 @@ mvebu_pci_bridge_emul_base_conf_write(struct pci_bridge_emul *bridge,
|
||
|
switch (reg) {
|
||
|
case PCI_COMMAND:
|
||
|
mvebu_writel(port, new, PCIE_CMD_OFF);
|
||
|
+
|
||
|
+ if ((old ^ new) & PCI_COMMAND_SERR)
|
||
|
+ mvebu_pcie_handle_irq_change(port);
|
||
|
break;
|
||
|
|
||
|
case PCI_IO_BASE:
|
||
|
@@ -776,6 +833,8 @@ mvebu_pci_bridge_emul_base_conf_write(struct pci_bridge_emul *bridge,
|
||
|
break;
|
||
|
|
||
|
case PCI_INTERRUPT_LINE:
|
||
|
+ if (((old ^ new) >> 16) & PCI_BRIDGE_CTL_SERR)
|
||
|
+ mvebu_pcie_handle_irq_change(port);
|
||
|
if (mask & (PCI_BRIDGE_CTL_BUS_RESET << 16)) {
|
||
|
u32 ctrl = mvebu_readl(port, PCIE_CTRL_OFF);
|
||
|
if (new & (PCI_BRIDGE_CTL_BUS_RESET << 16))
|
||
|
@@ -799,7 +858,18 @@ mvebu_pci_bridge_emul_pcie_conf_write(struct pci_bridge_emul *bridge,
|
||
|
|
||
|
switch (reg) {
|
||
|
case PCI_EXP_DEVCTL:
|
||
|
+ /*
|
||
|
+ * Armada370 data says these bits must always
|
||
|
+ * be zero when in root complex mode.
|
||
|
+ */
|
||
|
+ new &= ~(PCI_EXP_DEVCTL_URRE | PCI_EXP_DEVCTL_FERE |
|
||
|
+ PCI_EXP_DEVCTL_NFERE | PCI_EXP_DEVCTL_CERE);
|
||
|
+
|
||
|
mvebu_writel(port, new, PCIE_CAP_PCIEXP + PCI_EXP_DEVCTL);
|
||
|
+
|
||
|
+ if ((new ^ old) & (PCI_EXP_DEVCTL_FERE | PCI_EXP_DEVCTL_NFERE |
|
||
|
+ PCI_EXP_DEVCTL_CERE | PCI_EXP_DEVCTL_URRE))
|
||
|
+ mvebu_pcie_handle_irq_change(port);
|
||
|
break;
|
||
|
|
||
|
case PCI_EXP_LNKCTL:
|
||
|
@@ -850,6 +920,12 @@ mvebu_pci_bridge_emul_pcie_conf_write(struct pci_bridge_emul *bridge,
|
||
|
|
||
|
default:
|
||
|
break;
|
||
|
+
|
||
|
+ case PCI_EXP_RTCTL:
|
||
|
+ if ((new ^ old) & (PCI_EXP_RTCTL_SECEE | PCI_EXP_RTCTL_SENFEE |
|
||
|
+ PCI_EXP_RTCTL_SEFEE | PCI_EXP_RTCTL_PMEIE))
|
||
|
+ mvebu_pcie_handle_irq_change(port);
|
||
|
+ break;
|
||
|
}
|
||
|
}
|
||
|
|
||
|
diff --git a/drivers/pci/pci-bridge-emul.c b/drivers/pci/pci-bridge-emul.c
|
||
|
index d8d37b7ad0c5..003511971108 100644
|
||
|
--- a/drivers/pci/pci-bridge-emul.c
|
||
|
+++ b/drivers/pci/pci-bridge-emul.c
|
||
|
@@ -157,6 +157,7 @@ struct pci_bridge_reg_behavior pci_regs_behavior[PCI_STD_HEADER_SIZEOF / 4] = {
|
||
|
.rw = (GENMASK(7, 0) |
|
||
|
((PCI_BRIDGE_CTL_PARITY |
|
||
|
PCI_BRIDGE_CTL_SERR |
|
||
|
+ /* NOTE: PCIe does not allow ISA, VGA, MASTER_ABORT */
|
||
|
PCI_BRIDGE_CTL_ISA |
|
||
|
PCI_BRIDGE_CTL_VGA |
|
||
|
PCI_BRIDGE_CTL_MASTER_ABORT |
|
||
|
@@ -355,6 +356,7 @@ int pci_bridge_emul_init(struct pci_bridge_emul *bridge,
|
||
|
bridge->conf.header_type = PCI_HEADER_TYPE_BRIDGE;
|
||
|
bridge->conf.cache_line_size = 0x10;
|
||
|
bridge->conf.status = cpu_to_le16(PCI_STATUS_CAP_LIST);
|
||
|
+ bridge->conf.bridgectrl = cpu_to_le16(PCI_BRIDGE_CTL_SERR);
|
||
|
bridge->pci_regs_behavior = kmemdup(pci_regs_behavior,
|
||
|
sizeof(pci_regs_behavior),
|
||
|
GFP_KERNEL);
|
||
|
diff --git a/drivers/pci/pcie/aspm.c b/drivers/pci/pcie/aspm.c
|
||
|
index 4b4184563a92..7342af76f93d 100644
|
||
|
--- a/drivers/pci/pcie/aspm.c
|
||
|
+++ b/drivers/pci/pcie/aspm.c
|
||
|
@@ -656,6 +656,12 @@ static void pcie_aspm_cap_init(struct pcie_link_state *link, int blacklist)
|
||
|
pcie_capability_read_dword(child, PCI_EXP_LNKCAP, &child_lnkcap);
|
||
|
pcie_capability_read_word(parent, PCI_EXP_LNKCTL, &parent_lnkctl);
|
||
|
pcie_capability_read_word(child, PCI_EXP_LNKCTL, &child_lnkctl);
|
||
|
+dev_info(&parent->dev, "up support %x enabled %x\n",
|
||
|
+ (parent_lnkcap & PCI_EXP_LNKCAP_ASPMS) >> 10,
|
||
|
+ !!(parent_lnkctl & PCI_EXP_LNKCTL_ASPMC));
|
||
|
+dev_info(&parent->dev, "dn support %x enabled %x\n",
|
||
|
+ (child_lnkcap & PCI_EXP_LNKCAP_ASPMS) >> 10,
|
||
|
+ !!(child_lnkctl & PCI_EXP_LNKCTL_ASPMC));
|
||
|
|
||
|
/*
|
||
|
* Setup L0s state
|
||
|
diff --git a/drivers/pci/pcie/portdrv.c b/drivers/pci/pcie/portdrv.c
|
||
|
index 2cc2e60bcb39..1954487a1968 100644
|
||
|
--- a/drivers/pci/pcie/portdrv.c
|
||
|
+++ b/drivers/pci/pcie/portdrv.c
|
||
|
@@ -335,6 +335,7 @@ static int pcie_port_device_register(struct pci_dev *dev)
|
||
|
|
||
|
/* Get and check PCI Express port services */
|
||
|
capabilities = get_port_device_capability(dev);
|
||
|
+dev_info(&dev->dev, "PCIe capabilities: 0x%x\n", capabilities);
|
||
|
if (!capabilities)
|
||
|
return 0;
|
||
|
|
||
|
@@ -347,6 +348,7 @@ static int pcie_port_device_register(struct pci_dev *dev)
|
||
|
* if that is to be used.
|
||
|
*/
|
||
|
status = pcie_init_service_irqs(dev, irqs, capabilities);
|
||
|
+dev_info(&dev->dev, "init_service_irqs: %d\n", status);
|
||
|
if (status) {
|
||
|
capabilities &= PCIE_PORT_SERVICE_HP;
|
||
|
if (!capabilities)
|
||
|
--
|
||
|
cgit
|
||
|
|