From e74008847b59aca2586b5c92966cc702736aef7b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ond=C5=99ej=20Jirman?= Date: Sat, 1 May 2021 01:28:07 +0200 Subject: [PATCH 086/469] input: goodix: Don't disable regulators during suspend It does no harm to disable them, but on Pinephone we have other peripherals attached to the same power supplies, whose drivers will not reference the regulator, so powering down the regulators from Goodix driver will break those other devices. Until those drivers gain the regulator support, don't disable the regulators in Goodix driver. Signed-off-by: Ondrej Jirman --- drivers/input/touchscreen/goodix.c | 14 -------------- 1 file changed, 14 deletions(-) diff --git a/drivers/input/touchscreen/goodix.c b/drivers/input/touchscreen/goodix.c index 2a7d0e51b942..b645fe8473b5 100644 --- a/drivers/input/touchscreen/goodix.c +++ b/drivers/input/touchscreen/goodix.c @@ -1441,8 +1441,6 @@ static int goodix_suspend(struct device *dev) goodix_free_irq(ts); goodix_irq_direction_output(ts, 0); gpiod_direction_output(ts->gpiod_rst, 0); - regulator_disable(ts->avdd28); - regulator_disable(ts->vddio); return 0; } @@ -1492,18 +1490,6 @@ static int goodix_resume(struct device *dev) int error; if (ts->poweroff_in_suspend) { - error = regulator_enable(ts->avdd28); - if (error) { - dev_err(dev, "Regulator avdd28 enable failed.\n"); - return error; - } - - error = regulator_enable(ts->vddio); - if (error) { - dev_err(dev, "Regulator vddio enable failed.\n"); - return error; - } - error = goodix_reset(ts); if (error) { dev_err(dev, "Controller reset failed.\n"); -- 2.34.1