1691 lines
55 KiB
Diff
1691 lines
55 KiB
Diff
diff --git a/Makefile b/Makefile
|
|
index 46178c83906c..47a0a6c8272b 100644
|
|
--- a/Makefile
|
|
+++ b/Makefile
|
|
@@ -1,6 +1,6 @@
|
|
VERSION = 4
|
|
PATCHLEVEL = 4
|
|
-SUBLEVEL = 231
|
|
+SUBLEVEL = 232
|
|
EXTRAVERSION =
|
|
NAME = Blurry Fish Butt
|
|
|
|
@@ -607,7 +607,7 @@ ifeq ($(cc-name),clang)
|
|
ifneq ($(CROSS_COMPILE),)
|
|
CLANG_TARGET := --target=$(notdir $(CROSS_COMPILE:%-=%))
|
|
GCC_TOOLCHAIN_DIR := $(dir $(shell which $(CROSS_COMPILE)elfedit))
|
|
-CLANG_PREFIX := --prefix=$(GCC_TOOLCHAIN_DIR)
|
|
+CLANG_PREFIX := --prefix=$(GCC_TOOLCHAIN_DIR)$(notdir $(CROSS_COMPILE))
|
|
GCC_TOOLCHAIN := $(realpath $(GCC_TOOLCHAIN_DIR)/..)
|
|
endif
|
|
ifneq ($(GCC_TOOLCHAIN),)
|
|
diff --git a/arch/arm64/kernel/debug-monitors.c b/arch/arm64/kernel/debug-monitors.c
|
|
index 8e7675e5ce4a..77fbcabcd9e3 100644
|
|
--- a/arch/arm64/kernel/debug-monitors.c
|
|
+++ b/arch/arm64/kernel/debug-monitors.c
|
|
@@ -387,14 +387,14 @@ void user_rewind_single_step(struct task_struct *task)
|
|
* If single step is active for this thread, then set SPSR.SS
|
|
* to 1 to avoid returning to the active-pending state.
|
|
*/
|
|
- if (test_ti_thread_flag(task_thread_info(task), TIF_SINGLESTEP))
|
|
+ if (test_tsk_thread_flag(task, TIF_SINGLESTEP))
|
|
set_regs_spsr_ss(task_pt_regs(task));
|
|
}
|
|
NOKPROBE_SYMBOL(user_rewind_single_step);
|
|
|
|
void user_fastforward_single_step(struct task_struct *task)
|
|
{
|
|
- if (test_ti_thread_flag(task_thread_info(task), TIF_SINGLESTEP))
|
|
+ if (test_tsk_thread_flag(task, TIF_SINGLESTEP))
|
|
clear_regs_spsr_ss(task_pt_regs(task));
|
|
}
|
|
|
|
diff --git a/arch/parisc/include/asm/atomic.h b/arch/parisc/include/asm/atomic.h
|
|
index 1d109990a022..cb2590821707 100644
|
|
--- a/arch/parisc/include/asm/atomic.h
|
|
+++ b/arch/parisc/include/asm/atomic.h
|
|
@@ -208,6 +208,8 @@ atomic64_set(atomic64_t *v, s64 i)
|
|
_atomic_spin_unlock_irqrestore(v, flags);
|
|
}
|
|
|
|
+#define atomic64_set_release(v, i) atomic64_set((v), (i))
|
|
+
|
|
static __inline__ s64
|
|
atomic64_read(const atomic64_t *v)
|
|
{
|
|
diff --git a/arch/x86/kernel/fpu/signal.c b/arch/x86/kernel/fpu/signal.c
|
|
index 31fad2cbd734..8fc842dae3b3 100644
|
|
--- a/arch/x86/kernel/fpu/signal.c
|
|
+++ b/arch/x86/kernel/fpu/signal.c
|
|
@@ -317,10 +317,10 @@ static int __fpu__restore_sig(void __user *buf, void __user *buf_fx, int size)
|
|
sanitize_restored_xstate(tsk, &env, xfeatures, fx_only);
|
|
}
|
|
|
|
+ local_bh_disable();
|
|
fpu->fpstate_active = 1;
|
|
- preempt_disable();
|
|
fpu__restore(fpu);
|
|
- preempt_enable();
|
|
+ local_bh_enable();
|
|
|
|
return err;
|
|
} else {
|
|
diff --git a/arch/x86/math-emu/wm_sqrt.S b/arch/x86/math-emu/wm_sqrt.S
|
|
index d258f59564e1..3b40c98bbbd4 100644
|
|
--- a/arch/x86/math-emu/wm_sqrt.S
|
|
+++ b/arch/x86/math-emu/wm_sqrt.S
|
|
@@ -208,7 +208,7 @@ sqrt_stage_2_finish:
|
|
|
|
#ifdef PARANOID
|
|
/* It should be possible to get here only if the arg is ffff....ffff */
|
|
- cmp $0xffffffff,FPU_fsqrt_arg_1
|
|
+ cmpl $0xffffffff,FPU_fsqrt_arg_1
|
|
jnz sqrt_stage_2_error
|
|
#endif /* PARANOID */
|
|
|
|
diff --git a/arch/xtensa/kernel/setup.c b/arch/xtensa/kernel/setup.c
|
|
index 49ccbd9022f6..92f5a259e251 100644
|
|
--- a/arch/xtensa/kernel/setup.c
|
|
+++ b/arch/xtensa/kernel/setup.c
|
|
@@ -716,7 +716,8 @@ c_start(struct seq_file *f, loff_t *pos)
|
|
static void *
|
|
c_next(struct seq_file *f, void *v, loff_t *pos)
|
|
{
|
|
- return NULL;
|
|
+ ++*pos;
|
|
+ return c_start(f, pos);
|
|
}
|
|
|
|
static void
|
|
diff --git a/arch/xtensa/kernel/xtensa_ksyms.c b/arch/xtensa/kernel/xtensa_ksyms.c
|
|
index e2dd9109df63..00f17b5ec9c9 100644
|
|
--- a/arch/xtensa/kernel/xtensa_ksyms.c
|
|
+++ b/arch/xtensa/kernel/xtensa_ksyms.c
|
|
@@ -82,13 +82,13 @@ void __xtensa_libgcc_window_spill(void)
|
|
}
|
|
EXPORT_SYMBOL(__xtensa_libgcc_window_spill);
|
|
|
|
-unsigned long __sync_fetch_and_and_4(unsigned long *p, unsigned long v)
|
|
+unsigned int __sync_fetch_and_and_4(volatile void *p, unsigned int v)
|
|
{
|
|
BUG();
|
|
}
|
|
EXPORT_SYMBOL(__sync_fetch_and_and_4);
|
|
|
|
-unsigned long __sync_fetch_and_or_4(unsigned long *p, unsigned long v)
|
|
+unsigned int __sync_fetch_and_or_4(volatile void *p, unsigned int v)
|
|
{
|
|
BUG();
|
|
}
|
|
diff --git a/drivers/base/regmap/regmap-debugfs.c b/drivers/base/regmap/regmap-debugfs.c
|
|
index 3f0a7e262d69..ad5712f68c3e 100644
|
|
--- a/drivers/base/regmap/regmap-debugfs.c
|
|
+++ b/drivers/base/regmap/regmap-debugfs.c
|
|
@@ -194,6 +194,9 @@ static ssize_t regmap_read_debugfs(struct regmap *map, unsigned int from,
|
|
if (*ppos < 0 || !count)
|
|
return -EINVAL;
|
|
|
|
+ if (count > (PAGE_SIZE << (MAX_ORDER - 1)))
|
|
+ count = PAGE_SIZE << (MAX_ORDER - 1);
|
|
+
|
|
buf = kmalloc(count, GFP_KERNEL);
|
|
if (!buf)
|
|
return -ENOMEM;
|
|
@@ -342,6 +345,9 @@ static ssize_t regmap_reg_ranges_read_file(struct file *file,
|
|
if (*ppos < 0 || !count)
|
|
return -EINVAL;
|
|
|
|
+ if (count > (PAGE_SIZE << (MAX_ORDER - 1)))
|
|
+ count = PAGE_SIZE << (MAX_ORDER - 1);
|
|
+
|
|
buf = kmalloc(count, GFP_KERNEL);
|
|
if (!buf)
|
|
return -ENOMEM;
|
|
diff --git a/drivers/base/regmap/regmap.c b/drivers/base/regmap/regmap.c
|
|
index 77cabde977ed..4a4efc6f54b5 100644
|
|
--- a/drivers/base/regmap/regmap.c
|
|
+++ b/drivers/base/regmap/regmap.c
|
|
@@ -1106,7 +1106,7 @@ static int dev_get_regmap_match(struct device *dev, void *res, void *data)
|
|
|
|
/* If the user didn't specify a name match any */
|
|
if (data)
|
|
- return (*r)->name == data;
|
|
+ return !strcmp((*r)->name, data);
|
|
else
|
|
return 1;
|
|
}
|
|
diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/i2c/auxg94.c b/drivers/gpu/drm/nouveau/nvkm/subdev/i2c/auxg94.c
|
|
index 954f5b76bfcf..d44965f805fe 100644
|
|
--- a/drivers/gpu/drm/nouveau/nvkm/subdev/i2c/auxg94.c
|
|
+++ b/drivers/gpu/drm/nouveau/nvkm/subdev/i2c/auxg94.c
|
|
@@ -118,10 +118,10 @@ g94_i2c_aux_xfer(struct nvkm_i2c_aux *obj, bool retry,
|
|
if (retries)
|
|
udelay(400);
|
|
|
|
- /* transaction request, wait up to 1ms for it to complete */
|
|
+ /* transaction request, wait up to 2ms for it to complete */
|
|
nvkm_wr32(device, 0x00e4e4 + base, 0x00010000 | ctrl);
|
|
|
|
- timeout = 1000;
|
|
+ timeout = 2000;
|
|
do {
|
|
ctrl = nvkm_rd32(device, 0x00e4e4 + base);
|
|
udelay(1);
|
|
diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/i2c/auxgm204.c b/drivers/gpu/drm/nouveau/nvkm/subdev/i2c/auxgm204.c
|
|
index bed231b56dbd..7cac8fe372b6 100644
|
|
--- a/drivers/gpu/drm/nouveau/nvkm/subdev/i2c/auxgm204.c
|
|
+++ b/drivers/gpu/drm/nouveau/nvkm/subdev/i2c/auxgm204.c
|
|
@@ -118,10 +118,10 @@ gm204_i2c_aux_xfer(struct nvkm_i2c_aux *obj, bool retry,
|
|
if (retries)
|
|
udelay(400);
|
|
|
|
- /* transaction request, wait up to 1ms for it to complete */
|
|
+ /* transaction request, wait up to 2ms for it to complete */
|
|
nvkm_wr32(device, 0x00d954 + base, 0x00010000 | ctrl);
|
|
|
|
- timeout = 1000;
|
|
+ timeout = 2000;
|
|
do {
|
|
ctrl = nvkm_rd32(device, 0x00d954 + base);
|
|
udelay(1);
|
|
diff --git a/drivers/net/ethernet/marvell/sky2.c b/drivers/net/ethernet/marvell/sky2.c
|
|
index 8ba9eadc2079..3fb9cbdac3bf 100644
|
|
--- a/drivers/net/ethernet/marvell/sky2.c
|
|
+++ b/drivers/net/ethernet/marvell/sky2.c
|
|
@@ -215,7 +215,7 @@ io_error:
|
|
|
|
static inline u16 gm_phy_read(struct sky2_hw *hw, unsigned port, u16 reg)
|
|
{
|
|
- u16 v;
|
|
+ u16 v = 0;
|
|
__gm_phy_read(hw, port, reg, &v);
|
|
return v;
|
|
}
|
|
diff --git a/drivers/net/ethernet/smsc/smc91x.c b/drivers/net/ethernet/smsc/smc91x.c
|
|
index 7405f537beca..8531a7201968 100644
|
|
--- a/drivers/net/ethernet/smsc/smc91x.c
|
|
+++ b/drivers/net/ethernet/smsc/smc91x.c
|
|
@@ -2289,7 +2289,7 @@ static int smc_drv_probe(struct platform_device *pdev)
|
|
ret = try_toggle_control_gpio(&pdev->dev, &lp->power_gpio,
|
|
"power", 0, 0, 100);
|
|
if (ret)
|
|
- return ret;
|
|
+ goto out_free_netdev;
|
|
|
|
/*
|
|
* Optional reset GPIO configured? Minimum 100 ns reset needed
|
|
@@ -2298,7 +2298,7 @@ static int smc_drv_probe(struct platform_device *pdev)
|
|
ret = try_toggle_control_gpio(&pdev->dev, &lp->reset_gpio,
|
|
"reset", 0, 0, 100);
|
|
if (ret)
|
|
- return ret;
|
|
+ goto out_free_netdev;
|
|
|
|
/*
|
|
* Need to wait for optional EEPROM to load, max 750 us according
|
|
diff --git a/drivers/net/hippi/rrunner.c b/drivers/net/hippi/rrunner.c
|
|
index 313e006f74fe..6f3519123eb6 100644
|
|
--- a/drivers/net/hippi/rrunner.c
|
|
+++ b/drivers/net/hippi/rrunner.c
|
|
@@ -1250,7 +1250,7 @@ static int rr_open(struct net_device *dev)
|
|
rrpriv->info = NULL;
|
|
}
|
|
if (rrpriv->rx_ctrl) {
|
|
- pci_free_consistent(pdev, sizeof(struct ring_ctrl),
|
|
+ pci_free_consistent(pdev, 256 * sizeof(struct ring_ctrl),
|
|
rrpriv->rx_ctrl, rrpriv->rx_ctrl_dma);
|
|
rrpriv->rx_ctrl = NULL;
|
|
}
|
|
diff --git a/drivers/net/phy/dp83640.c b/drivers/net/phy/dp83640.c
|
|
index 847c9fc10f9a..0da80adc545a 100644
|
|
--- a/drivers/net/phy/dp83640.c
|
|
+++ b/drivers/net/phy/dp83640.c
|
|
@@ -1335,6 +1335,7 @@ static int dp83640_hwtstamp(struct phy_device *phydev, struct ifreq *ifr)
|
|
dp83640->hwts_rx_en = 1;
|
|
dp83640->layer = PTP_CLASS_L4;
|
|
dp83640->version = PTP_CLASS_V1;
|
|
+ cfg.rx_filter = HWTSTAMP_FILTER_PTP_V1_L4_EVENT;
|
|
break;
|
|
case HWTSTAMP_FILTER_PTP_V2_L4_EVENT:
|
|
case HWTSTAMP_FILTER_PTP_V2_L4_SYNC:
|
|
@@ -1342,6 +1343,7 @@ static int dp83640_hwtstamp(struct phy_device *phydev, struct ifreq *ifr)
|
|
dp83640->hwts_rx_en = 1;
|
|
dp83640->layer = PTP_CLASS_L4;
|
|
dp83640->version = PTP_CLASS_V2;
|
|
+ cfg.rx_filter = HWTSTAMP_FILTER_PTP_V2_L4_EVENT;
|
|
break;
|
|
case HWTSTAMP_FILTER_PTP_V2_L2_EVENT:
|
|
case HWTSTAMP_FILTER_PTP_V2_L2_SYNC:
|
|
@@ -1349,6 +1351,7 @@ static int dp83640_hwtstamp(struct phy_device *phydev, struct ifreq *ifr)
|
|
dp83640->hwts_rx_en = 1;
|
|
dp83640->layer = PTP_CLASS_L2;
|
|
dp83640->version = PTP_CLASS_V2;
|
|
+ cfg.rx_filter = HWTSTAMP_FILTER_PTP_V2_L2_EVENT;
|
|
break;
|
|
case HWTSTAMP_FILTER_PTP_V2_EVENT:
|
|
case HWTSTAMP_FILTER_PTP_V2_SYNC:
|
|
@@ -1356,6 +1359,7 @@ static int dp83640_hwtstamp(struct phy_device *phydev, struct ifreq *ifr)
|
|
dp83640->hwts_rx_en = 1;
|
|
dp83640->layer = PTP_CLASS_L4 | PTP_CLASS_L2;
|
|
dp83640->version = PTP_CLASS_V2;
|
|
+ cfg.rx_filter = HWTSTAMP_FILTER_PTP_V2_EVENT;
|
|
break;
|
|
default:
|
|
return -ERANGE;
|
|
diff --git a/drivers/net/usb/ax88172a.c b/drivers/net/usb/ax88172a.c
|
|
index 6b1d03b73eeb..6b734c7ffec3 100644
|
|
--- a/drivers/net/usb/ax88172a.c
|
|
+++ b/drivers/net/usb/ax88172a.c
|
|
@@ -245,6 +245,7 @@ static int ax88172a_bind(struct usbnet *dev, struct usb_interface *intf)
|
|
ret = asix_read_cmd(dev, AX_CMD_READ_NODE_ID, 0, 0, ETH_ALEN, buf);
|
|
if (ret < ETH_ALEN) {
|
|
netdev_err(dev->net, "Failed to read MAC address: %d\n", ret);
|
|
+ ret = -EIO;
|
|
goto free;
|
|
}
|
|
memcpy(dev->net->dev_addr, buf, ETH_ALEN);
|
|
diff --git a/drivers/net/wan/lapbether.c b/drivers/net/wan/lapbether.c
|
|
index 6676607164d6..f5657783fad4 100644
|
|
--- a/drivers/net/wan/lapbether.c
|
|
+++ b/drivers/net/wan/lapbether.c
|
|
@@ -308,7 +308,6 @@ static void lapbeth_setup(struct net_device *dev)
|
|
dev->netdev_ops = &lapbeth_netdev_ops;
|
|
dev->destructor = free_netdev;
|
|
dev->type = ARPHRD_X25;
|
|
- dev->hard_header_len = 3;
|
|
dev->mtu = 1000;
|
|
dev->addr_len = 0;
|
|
}
|
|
@@ -329,6 +328,14 @@ static int lapbeth_new_device(struct net_device *dev)
|
|
if (!ndev)
|
|
goto out;
|
|
|
|
+ /* When transmitting data:
|
|
+ * first this driver removes a pseudo header of 1 byte,
|
|
+ * then the lapb module prepends an LAPB header of at most 3 bytes,
|
|
+ * then this driver prepends a length field of 2 bytes,
|
|
+ * then the underlying Ethernet device prepends its own header.
|
|
+ */
|
|
+ ndev->hard_header_len = -1 + 3 + 2 + dev->hard_header_len;
|
|
+
|
|
lapbeth = netdev_priv(ndev);
|
|
lapbeth->axdev = ndev;
|
|
|
|
diff --git a/drivers/net/wan/x25_asy.c b/drivers/net/wan/x25_asy.c
|
|
index cd39025d2abf..022487d90aa3 100644
|
|
--- a/drivers/net/wan/x25_asy.c
|
|
+++ b/drivers/net/wan/x25_asy.c
|
|
@@ -186,7 +186,7 @@ static inline void x25_asy_unlock(struct x25_asy *sl)
|
|
netif_wake_queue(sl->dev);
|
|
}
|
|
|
|
-/* Send one completely decapsulated IP datagram to the IP layer. */
|
|
+/* Send an LAPB frame to the LAPB module to process. */
|
|
|
|
static void x25_asy_bump(struct x25_asy *sl)
|
|
{
|
|
@@ -198,13 +198,12 @@ static void x25_asy_bump(struct x25_asy *sl)
|
|
count = sl->rcount;
|
|
dev->stats.rx_bytes += count;
|
|
|
|
- skb = dev_alloc_skb(count+1);
|
|
+ skb = dev_alloc_skb(count);
|
|
if (skb == NULL) {
|
|
netdev_warn(sl->dev, "memory squeeze, dropping packet\n");
|
|
dev->stats.rx_dropped++;
|
|
return;
|
|
}
|
|
- skb_push(skb, 1); /* LAPB internal control */
|
|
memcpy(skb_put(skb, count), sl->rbuff, count);
|
|
skb->protocol = x25_type_trans(skb, sl->dev);
|
|
err = lapb_data_received(skb->dev, skb);
|
|
@@ -212,7 +211,6 @@ static void x25_asy_bump(struct x25_asy *sl)
|
|
kfree_skb(skb);
|
|
printk(KERN_DEBUG "x25_asy: data received err - %d\n", err);
|
|
} else {
|
|
- netif_rx(skb);
|
|
dev->stats.rx_packets++;
|
|
}
|
|
}
|
|
@@ -358,12 +356,21 @@ static netdev_tx_t x25_asy_xmit(struct sk_buff *skb,
|
|
*/
|
|
|
|
/*
|
|
- * Called when I frame data arrives. We did the work above - throw it
|
|
- * at the net layer.
|
|
+ * Called when I frame data arrive. We add a pseudo header for upper
|
|
+ * layers and pass it to upper layers.
|
|
*/
|
|
|
|
static int x25_asy_data_indication(struct net_device *dev, struct sk_buff *skb)
|
|
{
|
|
+ if (skb_cow(skb, 1)) {
|
|
+ kfree_skb(skb);
|
|
+ return NET_RX_DROP;
|
|
+ }
|
|
+ skb_push(skb, 1);
|
|
+ skb->data[0] = X25_IFACE_DATA;
|
|
+
|
|
+ skb->protocol = x25_type_trans(skb, dev);
|
|
+
|
|
return netif_rx(skb);
|
|
}
|
|
|
|
@@ -655,7 +662,7 @@ static void x25_asy_unesc(struct x25_asy *sl, unsigned char s)
|
|
switch (s) {
|
|
case X25_END:
|
|
if (!test_and_clear_bit(SLF_ERROR, &sl->flags) &&
|
|
- sl->rcount > 2)
|
|
+ sl->rcount >= 2)
|
|
x25_asy_bump(sl);
|
|
clear_bit(SLF_ESCAPE, &sl->flags);
|
|
sl->rcount = 0;
|
|
diff --git a/drivers/net/wireless/ath/ath9k/hif_usb.c b/drivers/net/wireless/ath/ath9k/hif_usb.c
|
|
index e2ed30b03af5..76d91859cfde 100644
|
|
--- a/drivers/net/wireless/ath/ath9k/hif_usb.c
|
|
+++ b/drivers/net/wireless/ath/ath9k/hif_usb.c
|
|
@@ -639,9 +639,9 @@ err:
|
|
|
|
static void ath9k_hif_usb_rx_cb(struct urb *urb)
|
|
{
|
|
- struct sk_buff *skb = (struct sk_buff *) urb->context;
|
|
- struct hif_device_usb *hif_dev =
|
|
- usb_get_intfdata(usb_ifnum_to_if(urb->dev, 0));
|
|
+ struct rx_buf *rx_buf = (struct rx_buf *)urb->context;
|
|
+ struct hif_device_usb *hif_dev = rx_buf->hif_dev;
|
|
+ struct sk_buff *skb = rx_buf->skb;
|
|
int ret;
|
|
|
|
if (!skb)
|
|
@@ -681,14 +681,15 @@ resubmit:
|
|
return;
|
|
free:
|
|
kfree_skb(skb);
|
|
+ kfree(rx_buf);
|
|
}
|
|
|
|
static void ath9k_hif_usb_reg_in_cb(struct urb *urb)
|
|
{
|
|
- struct sk_buff *skb = (struct sk_buff *) urb->context;
|
|
+ struct rx_buf *rx_buf = (struct rx_buf *)urb->context;
|
|
+ struct hif_device_usb *hif_dev = rx_buf->hif_dev;
|
|
+ struct sk_buff *skb = rx_buf->skb;
|
|
struct sk_buff *nskb;
|
|
- struct hif_device_usb *hif_dev =
|
|
- usb_get_intfdata(usb_ifnum_to_if(urb->dev, 0));
|
|
int ret;
|
|
|
|
if (!skb)
|
|
@@ -728,11 +729,13 @@ static void ath9k_hif_usb_reg_in_cb(struct urb *urb)
|
|
return;
|
|
}
|
|
|
|
+ rx_buf->skb = nskb;
|
|
+
|
|
usb_fill_int_urb(urb, hif_dev->udev,
|
|
usb_rcvintpipe(hif_dev->udev,
|
|
USB_REG_IN_PIPE),
|
|
nskb->data, MAX_REG_IN_BUF_SIZE,
|
|
- ath9k_hif_usb_reg_in_cb, nskb, 1);
|
|
+ ath9k_hif_usb_reg_in_cb, rx_buf, 1);
|
|
}
|
|
|
|
resubmit:
|
|
@@ -746,6 +749,7 @@ resubmit:
|
|
return;
|
|
free:
|
|
kfree_skb(skb);
|
|
+ kfree(rx_buf);
|
|
urb->context = NULL;
|
|
}
|
|
|
|
@@ -791,7 +795,7 @@ static int ath9k_hif_usb_alloc_tx_urbs(struct hif_device_usb *hif_dev)
|
|
init_usb_anchor(&hif_dev->mgmt_submitted);
|
|
|
|
for (i = 0; i < MAX_TX_URB_NUM; i++) {
|
|
- tx_buf = kzalloc(sizeof(struct tx_buf), GFP_KERNEL);
|
|
+ tx_buf = kzalloc(sizeof(*tx_buf), GFP_KERNEL);
|
|
if (!tx_buf)
|
|
goto err;
|
|
|
|
@@ -828,8 +832,9 @@ static void ath9k_hif_usb_dealloc_rx_urbs(struct hif_device_usb *hif_dev)
|
|
|
|
static int ath9k_hif_usb_alloc_rx_urbs(struct hif_device_usb *hif_dev)
|
|
{
|
|
- struct urb *urb = NULL;
|
|
+ struct rx_buf *rx_buf = NULL;
|
|
struct sk_buff *skb = NULL;
|
|
+ struct urb *urb = NULL;
|
|
int i, ret;
|
|
|
|
init_usb_anchor(&hif_dev->rx_submitted);
|
|
@@ -837,6 +842,12 @@ static int ath9k_hif_usb_alloc_rx_urbs(struct hif_device_usb *hif_dev)
|
|
|
|
for (i = 0; i < MAX_RX_URB_NUM; i++) {
|
|
|
|
+ rx_buf = kzalloc(sizeof(*rx_buf), GFP_KERNEL);
|
|
+ if (!rx_buf) {
|
|
+ ret = -ENOMEM;
|
|
+ goto err_rxb;
|
|
+ }
|
|
+
|
|
/* Allocate URB */
|
|
urb = usb_alloc_urb(0, GFP_KERNEL);
|
|
if (urb == NULL) {
|
|
@@ -851,11 +862,14 @@ static int ath9k_hif_usb_alloc_rx_urbs(struct hif_device_usb *hif_dev)
|
|
goto err_skb;
|
|
}
|
|
|
|
+ rx_buf->hif_dev = hif_dev;
|
|
+ rx_buf->skb = skb;
|
|
+
|
|
usb_fill_bulk_urb(urb, hif_dev->udev,
|
|
usb_rcvbulkpipe(hif_dev->udev,
|
|
USB_WLAN_RX_PIPE),
|
|
skb->data, MAX_RX_BUF_SIZE,
|
|
- ath9k_hif_usb_rx_cb, skb);
|
|
+ ath9k_hif_usb_rx_cb, rx_buf);
|
|
|
|
/* Anchor URB */
|
|
usb_anchor_urb(urb, &hif_dev->rx_submitted);
|
|
@@ -881,6 +895,8 @@ err_submit:
|
|
err_skb:
|
|
usb_free_urb(urb);
|
|
err_urb:
|
|
+ kfree(rx_buf);
|
|
+err_rxb:
|
|
ath9k_hif_usb_dealloc_rx_urbs(hif_dev);
|
|
return ret;
|
|
}
|
|
@@ -892,14 +908,21 @@ static void ath9k_hif_usb_dealloc_reg_in_urbs(struct hif_device_usb *hif_dev)
|
|
|
|
static int ath9k_hif_usb_alloc_reg_in_urbs(struct hif_device_usb *hif_dev)
|
|
{
|
|
- struct urb *urb = NULL;
|
|
+ struct rx_buf *rx_buf = NULL;
|
|
struct sk_buff *skb = NULL;
|
|
+ struct urb *urb = NULL;
|
|
int i, ret;
|
|
|
|
init_usb_anchor(&hif_dev->reg_in_submitted);
|
|
|
|
for (i = 0; i < MAX_REG_IN_URB_NUM; i++) {
|
|
|
|
+ rx_buf = kzalloc(sizeof(*rx_buf), GFP_KERNEL);
|
|
+ if (!rx_buf) {
|
|
+ ret = -ENOMEM;
|
|
+ goto err_rxb;
|
|
+ }
|
|
+
|
|
/* Allocate URB */
|
|
urb = usb_alloc_urb(0, GFP_KERNEL);
|
|
if (urb == NULL) {
|
|
@@ -914,11 +937,14 @@ static int ath9k_hif_usb_alloc_reg_in_urbs(struct hif_device_usb *hif_dev)
|
|
goto err_skb;
|
|
}
|
|
|
|
+ rx_buf->hif_dev = hif_dev;
|
|
+ rx_buf->skb = skb;
|
|
+
|
|
usb_fill_int_urb(urb, hif_dev->udev,
|
|
usb_rcvintpipe(hif_dev->udev,
|
|
USB_REG_IN_PIPE),
|
|
skb->data, MAX_REG_IN_BUF_SIZE,
|
|
- ath9k_hif_usb_reg_in_cb, skb, 1);
|
|
+ ath9k_hif_usb_reg_in_cb, rx_buf, 1);
|
|
|
|
/* Anchor URB */
|
|
usb_anchor_urb(urb, &hif_dev->reg_in_submitted);
|
|
@@ -944,6 +970,8 @@ err_submit:
|
|
err_skb:
|
|
usb_free_urb(urb);
|
|
err_urb:
|
|
+ kfree(rx_buf);
|
|
+err_rxb:
|
|
ath9k_hif_usb_dealloc_reg_in_urbs(hif_dev);
|
|
return ret;
|
|
}
|
|
diff --git a/drivers/net/wireless/ath/ath9k/hif_usb.h b/drivers/net/wireless/ath/ath9k/hif_usb.h
|
|
index a95cdf562611..835264c36595 100644
|
|
--- a/drivers/net/wireless/ath/ath9k/hif_usb.h
|
|
+++ b/drivers/net/wireless/ath/ath9k/hif_usb.h
|
|
@@ -84,6 +84,11 @@ struct tx_buf {
|
|
struct list_head list;
|
|
};
|
|
|
|
+struct rx_buf {
|
|
+ struct sk_buff *skb;
|
|
+ struct hif_device_usb *hif_dev;
|
|
+};
|
|
+
|
|
#define HIF_USB_TX_STOP BIT(0)
|
|
#define HIF_USB_TX_FLUSH BIT(1)
|
|
|
|
diff --git a/drivers/pinctrl/pinctrl-amd.h b/drivers/pinctrl/pinctrl-amd.h
|
|
index 7bfea47dbb47..f63417197a62 100644
|
|
--- a/drivers/pinctrl/pinctrl-amd.h
|
|
+++ b/drivers/pinctrl/pinctrl-amd.h
|
|
@@ -249,7 +249,7 @@ static const struct amd_pingroup kerncz_groups[] = {
|
|
{
|
|
.name = "uart0",
|
|
.pins = uart0_pins,
|
|
- .npins = 9,
|
|
+ .npins = 5,
|
|
},
|
|
{
|
|
.name = "uart1",
|
|
diff --git a/drivers/scsi/scsi_transport_spi.c b/drivers/scsi/scsi_transport_spi.c
|
|
index 319868f3f674..083cd11ce7d7 100644
|
|
--- a/drivers/scsi/scsi_transport_spi.c
|
|
+++ b/drivers/scsi/scsi_transport_spi.c
|
|
@@ -353,7 +353,7 @@ store_spi_transport_##field(struct device *dev, \
|
|
struct spi_transport_attrs *tp \
|
|
= (struct spi_transport_attrs *)&starget->starget_data; \
|
|
\
|
|
- if (i->f->set_##field) \
|
|
+ if (!i->f->set_##field) \
|
|
return -EINVAL; \
|
|
val = simple_strtoul(buf, NULL, 0); \
|
|
if (val > tp->max_##field) \
|
|
diff --git a/drivers/staging/comedi/drivers/addi_apci_1032.c b/drivers/staging/comedi/drivers/addi_apci_1032.c
|
|
index ccd1a91290bf..536a135cd00b 100644
|
|
--- a/drivers/staging/comedi/drivers/addi_apci_1032.c
|
|
+++ b/drivers/staging/comedi/drivers/addi_apci_1032.c
|
|
@@ -115,14 +115,22 @@ static int apci1032_cos_insn_config(struct comedi_device *dev,
|
|
unsigned int *data)
|
|
{
|
|
struct apci1032_private *devpriv = dev->private;
|
|
- unsigned int shift, oldmask;
|
|
+ unsigned int shift, oldmask, himask, lomask;
|
|
|
|
switch (data[0]) {
|
|
case INSN_CONFIG_DIGITAL_TRIG:
|
|
if (data[1] != 0)
|
|
return -EINVAL;
|
|
shift = data[3];
|
|
- oldmask = (1U << shift) - 1;
|
|
+ if (shift < 32) {
|
|
+ oldmask = (1U << shift) - 1;
|
|
+ himask = data[4] << shift;
|
|
+ lomask = data[5] << shift;
|
|
+ } else {
|
|
+ oldmask = 0xffffffffu;
|
|
+ himask = 0;
|
|
+ lomask = 0;
|
|
+ }
|
|
switch (data[2]) {
|
|
case COMEDI_DIGITAL_TRIG_DISABLE:
|
|
devpriv->ctrl = 0;
|
|
@@ -145,8 +153,8 @@ static int apci1032_cos_insn_config(struct comedi_device *dev,
|
|
devpriv->mode2 &= oldmask;
|
|
}
|
|
/* configure specified channels */
|
|
- devpriv->mode1 |= data[4] << shift;
|
|
- devpriv->mode2 |= data[5] << shift;
|
|
+ devpriv->mode1 |= himask;
|
|
+ devpriv->mode2 |= lomask;
|
|
break;
|
|
case COMEDI_DIGITAL_TRIG_ENABLE_LEVELS:
|
|
if (devpriv->ctrl != (APCI1032_CTRL_INT_ENA |
|
|
@@ -163,8 +171,8 @@ static int apci1032_cos_insn_config(struct comedi_device *dev,
|
|
devpriv->mode2 &= oldmask;
|
|
}
|
|
/* configure specified channels */
|
|
- devpriv->mode1 |= data[4] << shift;
|
|
- devpriv->mode2 |= data[5] << shift;
|
|
+ devpriv->mode1 |= himask;
|
|
+ devpriv->mode2 |= lomask;
|
|
break;
|
|
default:
|
|
return -EINVAL;
|
|
diff --git a/drivers/staging/comedi/drivers/addi_apci_1500.c b/drivers/staging/comedi/drivers/addi_apci_1500.c
|
|
index 79a8799b1262..c4e36fb6df9d 100644
|
|
--- a/drivers/staging/comedi/drivers/addi_apci_1500.c
|
|
+++ b/drivers/staging/comedi/drivers/addi_apci_1500.c
|
|
@@ -461,13 +461,14 @@ static int apci1500_di_cfg_trig(struct comedi_device *dev,
|
|
struct apci1500_private *devpriv = dev->private;
|
|
unsigned int trig = data[1];
|
|
unsigned int shift = data[3];
|
|
- unsigned int hi_mask = data[4] << shift;
|
|
- unsigned int lo_mask = data[5] << shift;
|
|
- unsigned int chan_mask = hi_mask | lo_mask;
|
|
- unsigned int old_mask = (1 << shift) - 1;
|
|
+ unsigned int hi_mask;
|
|
+ unsigned int lo_mask;
|
|
+ unsigned int chan_mask;
|
|
+ unsigned int old_mask;
|
|
unsigned int pm;
|
|
unsigned int pt;
|
|
unsigned int pp;
|
|
+ unsigned int invalid_chan;
|
|
|
|
if (trig > 1) {
|
|
dev_dbg(dev->class_dev,
|
|
@@ -475,7 +476,20 @@ static int apci1500_di_cfg_trig(struct comedi_device *dev,
|
|
return -EINVAL;
|
|
}
|
|
|
|
- if (chan_mask > 0xffff) {
|
|
+ if (shift <= 16) {
|
|
+ hi_mask = data[4] << shift;
|
|
+ lo_mask = data[5] << shift;
|
|
+ old_mask = (1U << shift) - 1;
|
|
+ invalid_chan = (data[4] | data[5]) >> (16 - shift);
|
|
+ } else {
|
|
+ hi_mask = 0;
|
|
+ lo_mask = 0;
|
|
+ old_mask = 0xffff;
|
|
+ invalid_chan = data[4] | data[5];
|
|
+ }
|
|
+ chan_mask = hi_mask | lo_mask;
|
|
+
|
|
+ if (invalid_chan) {
|
|
dev_dbg(dev->class_dev, "invalid digital trigger channel\n");
|
|
return -EINVAL;
|
|
}
|
|
diff --git a/drivers/staging/comedi/drivers/addi_apci_1564.c b/drivers/staging/comedi/drivers/addi_apci_1564.c
|
|
index f1ccfbd4c578..340e55c69263 100644
|
|
--- a/drivers/staging/comedi/drivers/addi_apci_1564.c
|
|
+++ b/drivers/staging/comedi/drivers/addi_apci_1564.c
|
|
@@ -288,14 +288,22 @@ static int apci1564_cos_insn_config(struct comedi_device *dev,
|
|
unsigned int *data)
|
|
{
|
|
struct apci1564_private *devpriv = dev->private;
|
|
- unsigned int shift, oldmask;
|
|
+ unsigned int shift, oldmask, himask, lomask;
|
|
|
|
switch (data[0]) {
|
|
case INSN_CONFIG_DIGITAL_TRIG:
|
|
if (data[1] != 0)
|
|
return -EINVAL;
|
|
shift = data[3];
|
|
- oldmask = (1U << shift) - 1;
|
|
+ if (shift < 32) {
|
|
+ oldmask = (1U << shift) - 1;
|
|
+ himask = data[4] << shift;
|
|
+ lomask = data[5] << shift;
|
|
+ } else {
|
|
+ oldmask = 0xffffffffu;
|
|
+ himask = 0;
|
|
+ lomask = 0;
|
|
+ }
|
|
switch (data[2]) {
|
|
case COMEDI_DIGITAL_TRIG_DISABLE:
|
|
devpriv->ctrl = 0;
|
|
@@ -319,8 +327,8 @@ static int apci1564_cos_insn_config(struct comedi_device *dev,
|
|
devpriv->mode2 &= oldmask;
|
|
}
|
|
/* configure specified channels */
|
|
- devpriv->mode1 |= data[4] << shift;
|
|
- devpriv->mode2 |= data[5] << shift;
|
|
+ devpriv->mode1 |= himask;
|
|
+ devpriv->mode2 |= lomask;
|
|
break;
|
|
case COMEDI_DIGITAL_TRIG_ENABLE_LEVELS:
|
|
if (devpriv->ctrl != (APCI1564_DI_IRQ_ENA |
|
|
@@ -337,8 +345,8 @@ static int apci1564_cos_insn_config(struct comedi_device *dev,
|
|
devpriv->mode2 &= oldmask;
|
|
}
|
|
/* configure specified channels */
|
|
- devpriv->mode1 |= data[4] << shift;
|
|
- devpriv->mode2 |= data[5] << shift;
|
|
+ devpriv->mode1 |= himask;
|
|
+ devpriv->mode2 |= lomask;
|
|
break;
|
|
default:
|
|
return -EINVAL;
|
|
diff --git a/drivers/staging/comedi/drivers/ni_6527.c b/drivers/staging/comedi/drivers/ni_6527.c
|
|
index 62a817e4cd64..5b904cf07bd1 100644
|
|
--- a/drivers/staging/comedi/drivers/ni_6527.c
|
|
+++ b/drivers/staging/comedi/drivers/ni_6527.c
|
|
@@ -341,7 +341,7 @@ static int ni6527_intr_insn_config(struct comedi_device *dev,
|
|
case COMEDI_DIGITAL_TRIG_ENABLE_EDGES:
|
|
/* check shift amount */
|
|
shift = data[3];
|
|
- if (shift >= s->n_chan) {
|
|
+ if (shift >= 32) {
|
|
mask = 0;
|
|
rising = 0;
|
|
falling = 0;
|
|
diff --git a/drivers/staging/wlan-ng/prism2usb.c b/drivers/staging/wlan-ng/prism2usb.c
|
|
index 8abf3f87a2d5..6da5c66bb3d5 100644
|
|
--- a/drivers/staging/wlan-ng/prism2usb.c
|
|
+++ b/drivers/staging/wlan-ng/prism2usb.c
|
|
@@ -60,11 +60,25 @@ static int prism2sta_probe_usb(struct usb_interface *interface,
|
|
const struct usb_device_id *id)
|
|
{
|
|
struct usb_device *dev;
|
|
-
|
|
+ const struct usb_endpoint_descriptor *epd;
|
|
+ const struct usb_host_interface *iface_desc = interface->cur_altsetting;
|
|
wlandevice_t *wlandev = NULL;
|
|
hfa384x_t *hw = NULL;
|
|
int result = 0;
|
|
|
|
+ if (iface_desc->desc.bNumEndpoints != 2) {
|
|
+ result = -ENODEV;
|
|
+ goto failed;
|
|
+ }
|
|
+
|
|
+ result = -EINVAL;
|
|
+ epd = &iface_desc->endpoint[1].desc;
|
|
+ if (!usb_endpoint_is_bulk_in(epd))
|
|
+ goto failed;
|
|
+ epd = &iface_desc->endpoint[2].desc;
|
|
+ if (!usb_endpoint_is_bulk_out(epd))
|
|
+ goto failed;
|
|
+
|
|
dev = interface_to_usbdev(interface);
|
|
wlandev = create_wlan();
|
|
if (wlandev == NULL) {
|
|
diff --git a/drivers/tty/serial/8250/8250_core.c b/drivers/tty/serial/8250/8250_core.c
|
|
index 39126460c1f5..e9ea9005a984 100644
|
|
--- a/drivers/tty/serial/8250/8250_core.c
|
|
+++ b/drivers/tty/serial/8250/8250_core.c
|
|
@@ -530,6 +530,7 @@ static void __init serial8250_isa_init_ports(void)
|
|
*/
|
|
up->mcr_mask = ~ALPHA_KLUDGE_MCR;
|
|
up->mcr_force = ALPHA_KLUDGE_MCR;
|
|
+ serial8250_set_defaults(up);
|
|
}
|
|
|
|
/* chain base port ops to support Remote Supervisor Adapter */
|
|
@@ -553,7 +554,6 @@ static void __init serial8250_isa_init_ports(void)
|
|
port->membase = old_serial_port[i].iomem_base;
|
|
port->iotype = old_serial_port[i].io_type;
|
|
port->regshift = old_serial_port[i].iomem_reg_shift;
|
|
- serial8250_set_defaults(up);
|
|
|
|
port->irqflags |= irqflag;
|
|
if (serial8250_isa_config != NULL)
|
|
diff --git a/drivers/tty/serial/8250/8250_mtk.c b/drivers/tty/serial/8250/8250_mtk.c
|
|
index 035810bbcd02..470ccf729d59 100644
|
|
--- a/drivers/tty/serial/8250/8250_mtk.c
|
|
+++ b/drivers/tty/serial/8250/8250_mtk.c
|
|
@@ -47,8 +47,21 @@ mtk8250_set_termios(struct uart_port *port, struct ktermios *termios,
|
|
struct uart_8250_port *up =
|
|
container_of(port, struct uart_8250_port, port);
|
|
|
|
+ /*
|
|
+ * Store the requested baud rate before calling the generic 8250
|
|
+ * set_termios method. Standard 8250 port expects bauds to be
|
|
+ * no higher than (uartclk / 16) so the baud will be clamped if it
|
|
+ * gets out of that bound. Mediatek 8250 port supports speed
|
|
+ * higher than that, therefore we'll get original baud rate back
|
|
+ * after calling the generic set_termios method and recalculate
|
|
+ * the speed later in this method.
|
|
+ */
|
|
+ baud = tty_termios_baud_rate(termios);
|
|
+
|
|
serial8250_do_set_termios(port, termios, old);
|
|
|
|
+ tty_termios_encode_baud_rate(termios, baud, baud);
|
|
+
|
|
/*
|
|
* Mediatek UARTs use an extra highspeed register (UART_MTK_HIGHS)
|
|
*
|
|
@@ -91,6 +104,11 @@ mtk8250_set_termios(struct uart_port *port, struct ktermios *termios,
|
|
*/
|
|
spin_lock_irqsave(&port->lock, flags);
|
|
|
|
+ /*
|
|
+ * Update the per-port timeout.
|
|
+ */
|
|
+ uart_update_timeout(port, termios->c_cflag, baud);
|
|
+
|
|
/* set DLAB we have cval saved in up->lcr from the call to the core */
|
|
serial_port_out(port, UART_LCR, up->lcr | UART_LCR_DLAB);
|
|
serial_dl_write(up, quot);
|
|
diff --git a/drivers/usb/gadget/udc/gr_udc.c b/drivers/usb/gadget/udc/gr_udc.c
|
|
index 594639e5cbf8..78168e1827b5 100644
|
|
--- a/drivers/usb/gadget/udc/gr_udc.c
|
|
+++ b/drivers/usb/gadget/udc/gr_udc.c
|
|
@@ -2001,9 +2001,12 @@ static int gr_ep_init(struct gr_udc *dev, int num, int is_in, u32 maxplimit)
|
|
|
|
if (num == 0) {
|
|
_req = gr_alloc_request(&ep->ep, GFP_ATOMIC);
|
|
+ if (!_req)
|
|
+ return -ENOMEM;
|
|
+
|
|
buf = devm_kzalloc(dev->dev, PAGE_SIZE, GFP_DMA | GFP_ATOMIC);
|
|
- if (!_req || !buf) {
|
|
- /* possible _req freed by gr_probe via gr_remove */
|
|
+ if (!buf) {
|
|
+ gr_free_request(&ep->ep, _req);
|
|
return -ENOMEM;
|
|
}
|
|
|
|
diff --git a/fs/btrfs/backref.c b/fs/btrfs/backref.c
|
|
index 81c5d07a2af1..228bfa19b745 100644
|
|
--- a/fs/btrfs/backref.c
|
|
+++ b/fs/btrfs/backref.c
|
|
@@ -1221,6 +1221,7 @@ static int __btrfs_find_all_roots(struct btrfs_trans_handle *trans,
|
|
if (ret < 0 && ret != -ENOENT) {
|
|
ulist_free(tmp);
|
|
ulist_free(*roots);
|
|
+ *roots = NULL;
|
|
return ret;
|
|
}
|
|
node = ulist_next(tmp, &uiter);
|
|
diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
|
|
index 55ce6543050d..dcae0cf4924b 100644
|
|
--- a/fs/btrfs/volumes.c
|
|
+++ b/fs/btrfs/volumes.c
|
|
@@ -6693,6 +6693,14 @@ int btrfs_read_chunk_tree(struct btrfs_root *root)
|
|
mutex_lock(&uuid_mutex);
|
|
lock_chunks(root);
|
|
|
|
+ /*
|
|
+ * It is possible for mount and umount to race in such a way that
|
|
+ * we execute this code path, but open_fs_devices failed to clear
|
|
+ * total_rw_bytes. We certainly want it cleared before reading the
|
|
+ * device items, so clear it here.
|
|
+ */
|
|
+ root->fs_info->fs_devices->total_rw_bytes = 0;
|
|
+
|
|
/*
|
|
* Read all device items, and then all the chunk items. All
|
|
* device items are found before any chunk item (their object id
|
|
diff --git a/fs/cifs/inode.c b/fs/cifs/inode.c
|
|
index a002e289a544..c18c26a78453 100644
|
|
--- a/fs/cifs/inode.c
|
|
+++ b/fs/cifs/inode.c
|
|
@@ -1737,7 +1737,6 @@ cifs_rename2(struct inode *source_dir, struct dentry *source_dentry,
|
|
FILE_UNIX_BASIC_INFO *info_buf_target;
|
|
unsigned int xid;
|
|
int rc, tmprc;
|
|
- bool new_target = d_really_is_negative(target_dentry);
|
|
|
|
if (flags & ~RENAME_NOREPLACE)
|
|
return -EINVAL;
|
|
@@ -1814,13 +1813,8 @@ cifs_rename2(struct inode *source_dir, struct dentry *source_dentry,
|
|
*/
|
|
|
|
unlink_target:
|
|
- /*
|
|
- * If the target dentry was created during the rename, try
|
|
- * unlinking it if it's not negative
|
|
- */
|
|
- if (new_target &&
|
|
- d_really_is_positive(target_dentry) &&
|
|
- (rc == -EACCES || rc == -EEXIST)) {
|
|
+ /* Try unlinking the target dentry if it's not negative */
|
|
+ if (d_really_is_positive(target_dentry) && (rc == -EACCES || rc == -EEXIST)) {
|
|
if (d_is_dir(target_dentry))
|
|
tmprc = cifs_rmdir(target_dir, target_dentry);
|
|
else
|
|
diff --git a/fs/nfs/direct.c b/fs/nfs/direct.c
|
|
index 4d76e9a97538..7789f0b9b999 100644
|
|
--- a/fs/nfs/direct.c
|
|
+++ b/fs/nfs/direct.c
|
|
@@ -385,6 +385,8 @@ static void nfs_direct_complete(struct nfs_direct_req *dreq, bool write)
|
|
if (write)
|
|
nfs_zap_mapping(inode, inode->i_mapping);
|
|
|
|
+ inode_dio_end(inode);
|
|
+
|
|
if (dreq->iocb) {
|
|
long res = (long) dreq->error;
|
|
if (!res)
|
|
@@ -394,10 +396,7 @@ static void nfs_direct_complete(struct nfs_direct_req *dreq, bool write)
|
|
|
|
complete_all(&dreq->completion);
|
|
|
|
- igrab(inode);
|
|
nfs_direct_req_release(dreq);
|
|
- inode_dio_end(inode);
|
|
- iput(inode);
|
|
}
|
|
|
|
static void nfs_direct_readpage_release(struct nfs_page *req)
|
|
@@ -538,10 +537,8 @@ static ssize_t nfs_direct_read_schedule_iovec(struct nfs_direct_req *dreq,
|
|
* generic layer handle the completion.
|
|
*/
|
|
if (requested_bytes == 0) {
|
|
- igrab(inode);
|
|
- nfs_direct_req_release(dreq);
|
|
inode_dio_end(inode);
|
|
- iput(inode);
|
|
+ nfs_direct_req_release(dreq);
|
|
return result < 0 ? result : -EIO;
|
|
}
|
|
|
|
@@ -942,10 +939,8 @@ static ssize_t nfs_direct_write_schedule_iovec(struct nfs_direct_req *dreq,
|
|
* generic layer handle the completion.
|
|
*/
|
|
if (requested_bytes == 0) {
|
|
- igrab(inode);
|
|
- nfs_direct_req_release(dreq);
|
|
inode_dio_end(inode);
|
|
- iput(inode);
|
|
+ nfs_direct_req_release(dreq);
|
|
return result < 0 ? result : -EIO;
|
|
}
|
|
|
|
diff --git a/fs/nfs/file.c b/fs/nfs/file.c
|
|
index eaa6697d256e..dc875cd0e11d 100644
|
|
--- a/fs/nfs/file.c
|
|
+++ b/fs/nfs/file.c
|
|
@@ -82,7 +82,6 @@ nfs_file_release(struct inode *inode, struct file *filp)
|
|
dprintk("NFS: release(%pD2)\n", filp);
|
|
|
|
nfs_inc_stats(inode, NFSIOS_VFSRELEASE);
|
|
- inode_dio_wait(inode);
|
|
nfs_file_clear_open_context(filp);
|
|
return 0;
|
|
}
|
|
diff --git a/fs/xfs/libxfs/xfs_bmap.c b/fs/xfs/libxfs/xfs_bmap.c
|
|
index d98ba57ef01a..c167bdaafc50 100644
|
|
--- a/fs/xfs/libxfs/xfs_bmap.c
|
|
+++ b/fs/xfs/libxfs/xfs_bmap.c
|
|
@@ -793,6 +793,8 @@ xfs_bmap_extents_to_btree(
|
|
*logflagsp = 0;
|
|
if ((error = xfs_alloc_vextent(&args))) {
|
|
xfs_iroot_realloc(ip, -1, whichfork);
|
|
+ ASSERT(ifp->if_broot == NULL);
|
|
+ XFS_IFORK_FMT_SET(ip, whichfork, XFS_DINODE_FMT_EXTENTS);
|
|
xfs_btree_del_cursor(cur, XFS_BTREE_ERROR);
|
|
return error;
|
|
}
|
|
diff --git a/include/linux/tcp.h b/include/linux/tcp.h
|
|
index 085da1707cea..b9e591582be9 100644
|
|
--- a/include/linux/tcp.h
|
|
+++ b/include/linux/tcp.h
|
|
@@ -211,7 +211,8 @@ struct tcp_sock {
|
|
u8 reord; /* reordering detected */
|
|
} rack;
|
|
u16 advmss; /* Advertised MSS */
|
|
- u8 unused;
|
|
+ u8 tlp_retrans:1, /* TLP is a retransmission */
|
|
+ unused_1:7;
|
|
u8 nonagle : 4,/* Disable Nagle algorithm? */
|
|
thin_lto : 1,/* Use linear timeouts for thin streams */
|
|
thin_dupack : 1,/* Fast retransmit on first dupack */
|
|
@@ -225,7 +226,7 @@ struct tcp_sock {
|
|
syn_data_acked:1,/* data in SYN is acked by SYN-ACK */
|
|
save_syn:1, /* Save headers of SYN packet */
|
|
is_cwnd_limited:1;/* forward progress limited by snd_cwnd? */
|
|
- u32 tlp_high_seq; /* snd_nxt at the time of TLP retransmit. */
|
|
+ u32 tlp_high_seq; /* snd_nxt at the time of TLP */
|
|
|
|
/* RTT measurement */
|
|
u32 srtt_us; /* smoothed round trip time << 3 in usecs */
|
|
diff --git a/kernel/events/core.c b/kernel/events/core.c
|
|
index feff3ba98cc9..388ce03155b4 100644
|
|
--- a/kernel/events/core.c
|
|
+++ b/kernel/events/core.c
|
|
@@ -3940,7 +3940,9 @@ EXPORT_SYMBOL_GPL(perf_event_read_value);
|
|
static int __perf_read_group_add(struct perf_event *leader,
|
|
u64 read_format, u64 *values)
|
|
{
|
|
+ struct perf_event_context *ctx = leader->ctx;
|
|
struct perf_event *sub;
|
|
+ unsigned long flags;
|
|
int n = 1; /* skip @nr */
|
|
int ret;
|
|
|
|
@@ -3970,12 +3972,15 @@ static int __perf_read_group_add(struct perf_event *leader,
|
|
if (read_format & PERF_FORMAT_ID)
|
|
values[n++] = primary_event_id(leader);
|
|
|
|
+ raw_spin_lock_irqsave(&ctx->lock, flags);
|
|
+
|
|
list_for_each_entry(sub, &leader->sibling_list, group_entry) {
|
|
values[n++] += perf_event_count(sub);
|
|
if (read_format & PERF_FORMAT_ID)
|
|
values[n++] = primary_event_id(sub);
|
|
}
|
|
|
|
+ raw_spin_unlock_irqrestore(&ctx->lock, flags);
|
|
return 0;
|
|
}
|
|
|
|
diff --git a/kernel/events/uprobes.c b/kernel/events/uprobes.c
|
|
index e7dabb254404..d937fbbc3642 100644
|
|
--- a/kernel/events/uprobes.c
|
|
+++ b/kernel/events/uprobes.c
|
|
@@ -1875,7 +1875,7 @@ static void handle_swbp(struct pt_regs *regs)
|
|
if (!uprobe) {
|
|
if (is_swbp > 0) {
|
|
/* No matching uprobe; signal SIGTRAP. */
|
|
- send_sig(SIGTRAP, current, 0);
|
|
+ force_sig(SIGTRAP, current);
|
|
} else {
|
|
/*
|
|
* Either we raced with uprobe_unregister() or we can't
|
|
diff --git a/mm/memcontrol.c b/mm/memcontrol.c
|
|
index cb98a1889c8c..617feca8d094 100644
|
|
--- a/mm/memcontrol.c
|
|
+++ b/mm/memcontrol.c
|
|
@@ -4889,7 +4889,6 @@ static void __mem_cgroup_clear_mc(void)
|
|
if (!mem_cgroup_is_root(mc.to))
|
|
page_counter_uncharge(&mc.to->memory, mc.moved_swap);
|
|
|
|
- mem_cgroup_id_get_many(mc.to, mc.moved_swap);
|
|
css_put_many(&mc.to->css, mc.moved_swap);
|
|
|
|
mc.moved_swap = 0;
|
|
@@ -5067,7 +5066,8 @@ put: /* get_mctgt_type() gets the page */
|
|
ent = target.ent;
|
|
if (!mem_cgroup_move_swap_account(ent, mc.from, mc.to)) {
|
|
mc.precharge--;
|
|
- /* we fixup refcnts and charges later. */
|
|
+ mem_cgroup_id_get_many(mc.to, 1);
|
|
+ /* we fixup other refcnts and charges later. */
|
|
mc.moved_swap++;
|
|
}
|
|
break;
|
|
diff --git a/net/ax25/af_ax25.c b/net/ax25/af_ax25.c
|
|
index 02be8ee23271..64fede18aa33 100644
|
|
--- a/net/ax25/af_ax25.c
|
|
+++ b/net/ax25/af_ax25.c
|
|
@@ -1191,7 +1191,10 @@ static int __must_check ax25_connect(struct socket *sock,
|
|
if (addr_len > sizeof(struct sockaddr_ax25) &&
|
|
fsa->fsa_ax25.sax25_ndigis != 0) {
|
|
/* Valid number of digipeaters ? */
|
|
- if (fsa->fsa_ax25.sax25_ndigis < 1 || fsa->fsa_ax25.sax25_ndigis > AX25_MAX_DIGIS) {
|
|
+ if (fsa->fsa_ax25.sax25_ndigis < 1 ||
|
|
+ fsa->fsa_ax25.sax25_ndigis > AX25_MAX_DIGIS ||
|
|
+ addr_len < sizeof(struct sockaddr_ax25) +
|
|
+ sizeof(ax25_address) * fsa->fsa_ax25.sax25_ndigis) {
|
|
err = -EINVAL;
|
|
goto out_release;
|
|
}
|
|
@@ -1510,7 +1513,10 @@ static int ax25_sendmsg(struct socket *sock, struct msghdr *msg, size_t len)
|
|
struct full_sockaddr_ax25 *fsa = (struct full_sockaddr_ax25 *)usax;
|
|
|
|
/* Valid number of digipeaters ? */
|
|
- if (usax->sax25_ndigis < 1 || usax->sax25_ndigis > AX25_MAX_DIGIS) {
|
|
+ if (usax->sax25_ndigis < 1 ||
|
|
+ usax->sax25_ndigis > AX25_MAX_DIGIS ||
|
|
+ addr_len < sizeof(struct sockaddr_ax25) +
|
|
+ sizeof(ax25_address) * usax->sax25_ndigis) {
|
|
err = -EINVAL;
|
|
goto out;
|
|
}
|
|
diff --git a/net/core/net-sysfs.c b/net/core/net-sysfs.c
|
|
index 579d351f6ddd..c976fd132c3b 100644
|
|
--- a/net/core/net-sysfs.c
|
|
+++ b/net/core/net-sysfs.c
|
|
@@ -999,7 +999,7 @@ static ssize_t show_trans_timeout(struct netdev_queue *queue,
|
|
trans_timeout = queue->trans_timeout;
|
|
spin_unlock_irq(&queue->_xmit_lock);
|
|
|
|
- return sprintf(buf, "%lu", trans_timeout);
|
|
+ return sprintf(buf, fmt_ulong, trans_timeout);
|
|
}
|
|
|
|
#ifdef CONFIG_XPS
|
|
diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c
|
|
index e2066f2f19b4..9215ee1de494 100644
|
|
--- a/net/ipv4/tcp_input.c
|
|
+++ b/net/ipv4/tcp_input.c
|
|
@@ -3517,10 +3517,8 @@ static void tcp_replace_ts_recent(struct tcp_sock *tp, u32 seq)
|
|
}
|
|
}
|
|
|
|
-/* This routine deals with acks during a TLP episode.
|
|
- * We mark the end of a TLP episode on receiving TLP dupack or when
|
|
- * ack is after tlp_high_seq.
|
|
- * Ref: loss detection algorithm in draft-dukkipati-tcpm-tcp-loss-probe.
|
|
+/* This routine deals with acks during a TLP episode and ends an episode by
|
|
+ * resetting tlp_high_seq. Ref: TLP algorithm in draft-ietf-tcpm-rack
|
|
*/
|
|
static void tcp_process_tlp_ack(struct sock *sk, u32 ack, int flag)
|
|
{
|
|
@@ -3529,7 +3527,10 @@ static void tcp_process_tlp_ack(struct sock *sk, u32 ack, int flag)
|
|
if (before(ack, tp->tlp_high_seq))
|
|
return;
|
|
|
|
- if (flag & FLAG_DSACKING_ACK) {
|
|
+ if (!tp->tlp_retrans) {
|
|
+ /* TLP of new data has been acknowledged */
|
|
+ tp->tlp_high_seq = 0;
|
|
+ } else if (flag & FLAG_DSACKING_ACK) {
|
|
/* This DSACK means original and TLP probe arrived; no loss */
|
|
tp->tlp_high_seq = 0;
|
|
} else if (after(ack, tp->tlp_high_seq)) {
|
|
diff --git a/net/ipv4/tcp_output.c b/net/ipv4/tcp_output.c
|
|
index 6c8966dcf612..b218138874cc 100644
|
|
--- a/net/ipv4/tcp_output.c
|
|
+++ b/net/ipv4/tcp_output.c
|
|
@@ -2271,6 +2271,11 @@ void tcp_send_loss_probe(struct sock *sk)
|
|
int pcount;
|
|
int mss = tcp_current_mss(sk);
|
|
|
|
+ /* At most one outstanding TLP */
|
|
+ if (tp->tlp_high_seq)
|
|
+ goto rearm_timer;
|
|
+
|
|
+ tp->tlp_retrans = 0;
|
|
skb = tcp_send_head(sk);
|
|
if (skb) {
|
|
if (tcp_snd_wnd_test(tp, skb, mss)) {
|
|
@@ -2293,10 +2298,6 @@ void tcp_send_loss_probe(struct sock *sk)
|
|
return;
|
|
}
|
|
|
|
- /* At most one outstanding TLP retransmission. */
|
|
- if (tp->tlp_high_seq)
|
|
- goto rearm_timer;
|
|
-
|
|
if (skb_still_in_host_queue(sk, skb))
|
|
goto rearm_timer;
|
|
|
|
@@ -2317,10 +2318,12 @@ void tcp_send_loss_probe(struct sock *sk)
|
|
if (__tcp_retransmit_skb(sk, skb))
|
|
goto rearm_timer;
|
|
|
|
+ tp->tlp_retrans = 1;
|
|
+
|
|
+probe_sent:
|
|
/* Record snd_nxt for loss detection. */
|
|
tp->tlp_high_seq = tp->snd_nxt;
|
|
|
|
-probe_sent:
|
|
NET_INC_STATS_BH(sock_net(sk), LINUX_MIB_TCPLOSSPROBES);
|
|
/* Reset s.t. tcp_rearm_rto will restart timer from now */
|
|
inet_csk(sk)->icsk_pending = 0;
|
|
diff --git a/net/ipv4/udp.c b/net/ipv4/udp.c
|
|
index bb306996c15e..5464fd210230 100644
|
|
--- a/net/ipv4/udp.c
|
|
+++ b/net/ipv4/udp.c
|
|
@@ -1558,7 +1558,7 @@ int udp_queue_rcv_skb(struct sock *sk, struct sk_buff *skb)
|
|
/*
|
|
* UDP-Lite specific tests, ignored on UDP sockets
|
|
*/
|
|
- if ((is_udplite & UDPLITE_RECV_CC) && UDP_SKB_CB(skb)->partial_cov) {
|
|
+ if ((up->pcflag & UDPLITE_RECV_CC) && UDP_SKB_CB(skb)->partial_cov) {
|
|
|
|
/*
|
|
* MIB statistics other than incrementing the error count are
|
|
diff --git a/net/ipv6/ip6_gre.c b/net/ipv6/ip6_gre.c
|
|
index 546172bfaba1..6efe6b101d3f 100644
|
|
--- a/net/ipv6/ip6_gre.c
|
|
+++ b/net/ipv6/ip6_gre.c
|
|
@@ -1355,15 +1355,16 @@ static void ip6gre_destroy_tunnels(struct net *net, struct list_head *head)
|
|
static int __net_init ip6gre_init_net(struct net *net)
|
|
{
|
|
struct ip6gre_net *ign = net_generic(net, ip6gre_net_id);
|
|
+ struct net_device *ndev;
|
|
int err;
|
|
|
|
- ign->fb_tunnel_dev = alloc_netdev(sizeof(struct ip6_tnl), "ip6gre0",
|
|
- NET_NAME_UNKNOWN,
|
|
- ip6gre_tunnel_setup);
|
|
- if (!ign->fb_tunnel_dev) {
|
|
+ ndev = alloc_netdev(sizeof(struct ip6_tnl), "ip6gre0",
|
|
+ NET_NAME_UNKNOWN, ip6gre_tunnel_setup);
|
|
+ if (!ndev) {
|
|
err = -ENOMEM;
|
|
goto err_alloc_dev;
|
|
}
|
|
+ ign->fb_tunnel_dev = ndev;
|
|
dev_net_set(ign->fb_tunnel_dev, net);
|
|
/* FB netdevice is special: we have one, and only one per netns.
|
|
* Allowing to move it to another netns is clearly unsafe.
|
|
@@ -1383,7 +1384,7 @@ static int __net_init ip6gre_init_net(struct net *net)
|
|
return 0;
|
|
|
|
err_reg_dev:
|
|
- ip6gre_dev_free(ign->fb_tunnel_dev);
|
|
+ ip6gre_dev_free(ndev);
|
|
err_alloc_dev:
|
|
return err;
|
|
}
|
|
diff --git a/net/ipv6/udp.c b/net/ipv6/udp.c
|
|
index 73f111206e36..79c583004575 100644
|
|
--- a/net/ipv6/udp.c
|
|
+++ b/net/ipv6/udp.c
|
|
@@ -672,7 +672,7 @@ int udpv6_queue_rcv_skb(struct sock *sk, struct sk_buff *skb)
|
|
/*
|
|
* UDP-Lite specific tests, ignored on UDP sockets (see net/ipv4/udp.c).
|
|
*/
|
|
- if ((is_udplite & UDPLITE_RECV_CC) && UDP_SKB_CB(skb)->partial_cov) {
|
|
+ if ((up->pcflag & UDPLITE_RECV_CC) && UDP_SKB_CB(skb)->partial_cov) {
|
|
|
|
if (up->pcrlen == 0) { /* full coverage was set */
|
|
net_dbg_ratelimited("UDPLITE6: partial coverage %d while full coverage %d requested\n",
|
|
diff --git a/net/mac80211/rx.c b/net/mac80211/rx.c
|
|
index a74a6ff18f91..886dce84e70c 100644
|
|
--- a/net/mac80211/rx.c
|
|
+++ b/net/mac80211/rx.c
|
|
@@ -1963,6 +1963,7 @@ static int ieee80211_802_1x_port_control(struct ieee80211_rx_data *rx)
|
|
|
|
static int ieee80211_drop_unencrypted(struct ieee80211_rx_data *rx, __le16 fc)
|
|
{
|
|
+ struct ieee80211_hdr *hdr = (void *)rx->skb->data;
|
|
struct sk_buff *skb = rx->skb;
|
|
struct ieee80211_rx_status *status = IEEE80211_SKB_RXCB(skb);
|
|
|
|
@@ -1973,6 +1974,31 @@ static int ieee80211_drop_unencrypted(struct ieee80211_rx_data *rx, __le16 fc)
|
|
if (status->flag & RX_FLAG_DECRYPTED)
|
|
return 0;
|
|
|
|
+ /* check mesh EAPOL frames first */
|
|
+ if (unlikely(rx->sta && ieee80211_vif_is_mesh(&rx->sdata->vif) &&
|
|
+ ieee80211_is_data(fc))) {
|
|
+ struct ieee80211s_hdr *mesh_hdr;
|
|
+ u16 hdr_len = ieee80211_hdrlen(fc);
|
|
+ u16 ethertype_offset;
|
|
+ __be16 ethertype;
|
|
+
|
|
+ if (!ether_addr_equal(hdr->addr1, rx->sdata->vif.addr))
|
|
+ goto drop_check;
|
|
+
|
|
+ /* make sure fixed part of mesh header is there, also checks skb len */
|
|
+ if (!pskb_may_pull(rx->skb, hdr_len + 6))
|
|
+ goto drop_check;
|
|
+
|
|
+ mesh_hdr = (struct ieee80211s_hdr *)(skb->data + hdr_len);
|
|
+ ethertype_offset = hdr_len + ieee80211_get_mesh_hdrlen(mesh_hdr) +
|
|
+ sizeof(rfc1042_header);
|
|
+
|
|
+ if (skb_copy_bits(rx->skb, ethertype_offset, ðertype, 2) == 0 &&
|
|
+ ethertype == rx->sdata->control_port_protocol)
|
|
+ return 0;
|
|
+ }
|
|
+
|
|
+drop_check:
|
|
/* Drop unencrypted frames if key is set. */
|
|
if (unlikely(!ieee80211_has_protected(fc) &&
|
|
!ieee80211_is_any_nullfunc(fc) &&
|
|
diff --git a/net/rxrpc/ar-output.c b/net/rxrpc/ar-output.c
|
|
index 14c4e12c47b0..a1997f9a447a 100644
|
|
--- a/net/rxrpc/ar-output.c
|
|
+++ b/net/rxrpc/ar-output.c
|
|
@@ -533,7 +533,7 @@ static int rxrpc_send_data(struct rxrpc_sock *rx,
|
|
/* this should be in poll */
|
|
sk_clear_bit(SOCKWQ_ASYNC_NOSPACE, sk);
|
|
|
|
- if (sk->sk_err || (sk->sk_shutdown & SEND_SHUTDOWN))
|
|
+ if (sk->sk_shutdown & SEND_SHUTDOWN)
|
|
return -EPIPE;
|
|
|
|
more = msg->msg_flags & MSG_MORE;
|
|
diff --git a/net/rxrpc/ar-recvmsg.c b/net/rxrpc/ar-recvmsg.c
|
|
index b92beded7459..cb9affdb1e87 100644
|
|
--- a/net/rxrpc/ar-recvmsg.c
|
|
+++ b/net/rxrpc/ar-recvmsg.c
|
|
@@ -78,7 +78,7 @@ int rxrpc_recvmsg(struct socket *sock, struct msghdr *msg, size_t len,
|
|
release_sock(&rx->sk);
|
|
if (continue_call)
|
|
rxrpc_put_call(continue_call);
|
|
- return -ENODATA;
|
|
+ return -EAGAIN;
|
|
}
|
|
}
|
|
|
|
diff --git a/scripts/decode_stacktrace.sh b/scripts/decode_stacktrace.sh
|
|
index 4f5e76f76b9d..003968cb04d4 100755
|
|
--- a/scripts/decode_stacktrace.sh
|
|
+++ b/scripts/decode_stacktrace.sh
|
|
@@ -63,8 +63,8 @@ parse_symbol() {
|
|
return
|
|
fi
|
|
|
|
- # Strip out the base of the path
|
|
- code=${code#$basepath/}
|
|
+ # Strip out the base of the path on each line
|
|
+ code=$(while read -r line; do echo "${line#$basepath/}"; done <<< "$code")
|
|
|
|
# In the case of inlines, move everything to same line
|
|
code=${code//$'\n'/' '}
|
|
diff --git a/sound/core/info.c b/sound/core/info.c
|
|
index 358a6947342d..8a6fa8fd0aab 100644
|
|
--- a/sound/core/info.c
|
|
+++ b/sound/core/info.c
|
|
@@ -634,7 +634,9 @@ int snd_info_get_line(struct snd_info_buffer *buffer, char *line, int len)
|
|
{
|
|
int c = -1;
|
|
|
|
- if (snd_BUG_ON(!buffer || !buffer->buffer))
|
|
+ if (snd_BUG_ON(!buffer))
|
|
+ return 1;
|
|
+ if (!buffer->buffer)
|
|
return 1;
|
|
if (len <= 0 || buffer->stop || buffer->error)
|
|
return 1;
|
|
diff --git a/sound/soc/codecs/rt5670.h b/sound/soc/codecs/rt5670.h
|
|
index 3f1b0f1df809..e4e31e82311d 100644
|
|
--- a/sound/soc/codecs/rt5670.h
|
|
+++ b/sound/soc/codecs/rt5670.h
|
|
@@ -760,7 +760,7 @@
|
|
#define RT5670_PWR_VREF2_BIT 4
|
|
#define RT5670_PWR_FV2 (0x1 << 3)
|
|
#define RT5670_PWR_FV2_BIT 3
|
|
-#define RT5670_LDO_SEL_MASK (0x3)
|
|
+#define RT5670_LDO_SEL_MASK (0x7)
|
|
#define RT5670_LDO_SEL_SFT 0
|
|
|
|
/* Power Management for Analog 2 (0x64) */
|
|
diff --git a/tools/perf/builtin-script.c b/tools/perf/builtin-script.c
|
|
index 20f0e27918dd..acd460303d1a 100644
|
|
--- a/tools/perf/builtin-script.c
|
|
+++ b/tools/perf/builtin-script.c
|
|
@@ -1245,7 +1245,7 @@ static int is_directory(const char *base_path, const struct dirent *dent)
|
|
char path[PATH_MAX];
|
|
struct stat st;
|
|
|
|
- sprintf(path, "%s/%s", base_path, dent->d_name);
|
|
+ scnprintf(path, PATH_MAX, "%s/%s", base_path, dent->d_name);
|
|
if (stat(path, &st))
|
|
return 0;
|
|
|
|
@@ -1426,8 +1426,8 @@ static int list_available_scripts(const struct option *opt __maybe_unused,
|
|
return -1;
|
|
|
|
for_each_lang(scripts_path, scripts_dir, lang_dirent) {
|
|
- snprintf(lang_path, MAXPATHLEN, "%s/%s/bin", scripts_path,
|
|
- lang_dirent->d_name);
|
|
+ scnprintf(lang_path, MAXPATHLEN, "%s/%s/bin", scripts_path,
|
|
+ lang_dirent->d_name);
|
|
lang_dir = opendir(lang_path);
|
|
if (!lang_dir)
|
|
continue;
|
|
@@ -1436,8 +1436,8 @@ static int list_available_scripts(const struct option *opt __maybe_unused,
|
|
script_root = get_script_root(script_dirent, REPORT_SUFFIX);
|
|
if (script_root) {
|
|
desc = script_desc__findnew(script_root);
|
|
- snprintf(script_path, MAXPATHLEN, "%s/%s",
|
|
- lang_path, script_dirent->d_name);
|
|
+ scnprintf(script_path, MAXPATHLEN, "%s/%s",
|
|
+ lang_path, script_dirent->d_name);
|
|
read_script_info(desc, script_path);
|
|
free(script_root);
|
|
}
|
|
@@ -1473,7 +1473,7 @@ static int check_ev_match(char *dir_name, char *scriptname,
|
|
int match, len;
|
|
FILE *fp;
|
|
|
|
- sprintf(filename, "%s/bin/%s-record", dir_name, scriptname);
|
|
+ scnprintf(filename, MAXPATHLEN, "%s/bin/%s-record", dir_name, scriptname);
|
|
|
|
fp = fopen(filename, "r");
|
|
if (!fp)
|
|
@@ -1549,8 +1549,8 @@ int find_scripts(char **scripts_array, char **scripts_path_array)
|
|
}
|
|
|
|
for_each_lang(scripts_path, scripts_dir, lang_dirent) {
|
|
- snprintf(lang_path, MAXPATHLEN, "%s/%s", scripts_path,
|
|
- lang_dirent->d_name);
|
|
+ scnprintf(lang_path, MAXPATHLEN, "%s/%s", scripts_path,
|
|
+ lang_dirent->d_name);
|
|
#ifdef NO_LIBPERL
|
|
if (strstr(lang_path, "perl"))
|
|
continue;
|
|
@@ -1605,8 +1605,8 @@ static char *get_script_path(const char *script_root, const char *suffix)
|
|
return NULL;
|
|
|
|
for_each_lang(scripts_path, scripts_dir, lang_dirent) {
|
|
- snprintf(lang_path, MAXPATHLEN, "%s/%s/bin", scripts_path,
|
|
- lang_dirent->d_name);
|
|
+ scnprintf(lang_path, MAXPATHLEN, "%s/%s/bin", scripts_path,
|
|
+ lang_dirent->d_name);
|
|
lang_dir = opendir(lang_path);
|
|
if (!lang_dir)
|
|
continue;
|
|
@@ -1617,8 +1617,8 @@ static char *get_script_path(const char *script_root, const char *suffix)
|
|
free(__script_root);
|
|
closedir(lang_dir);
|
|
closedir(scripts_dir);
|
|
- snprintf(script_path, MAXPATHLEN, "%s/%s",
|
|
- lang_path, script_dirent->d_name);
|
|
+ scnprintf(script_path, MAXPATHLEN, "%s/%s",
|
|
+ lang_path, script_dirent->d_name);
|
|
return strdup(script_path);
|
|
}
|
|
free(__script_root);
|
|
diff --git a/tools/perf/tests/attr.c b/tools/perf/tests/attr.c
|
|
index 79547c225c14..9c81fbfb16d2 100644
|
|
--- a/tools/perf/tests/attr.c
|
|
+++ b/tools/perf/tests/attr.c
|
|
@@ -147,8 +147,8 @@ static int run_dir(const char *d, const char *perf)
|
|
if (verbose)
|
|
vcnt++;
|
|
|
|
- snprintf(cmd, 3*PATH_MAX, PYTHON " %s/attr.py -d %s/attr/ -p %s %.*s",
|
|
- d, d, perf, vcnt, v);
|
|
+ scnprintf(cmd, 3*PATH_MAX, PYTHON " %s/attr.py -d %s/attr/ -p %s %.*s",
|
|
+ d, d, perf, vcnt, v);
|
|
|
|
return system(cmd) ? TEST_FAIL : TEST_OK;
|
|
}
|
|
diff --git a/tools/perf/tests/pmu.c b/tools/perf/tests/pmu.c
|
|
index faa04e9d5d5f..b776831ceeea 100644
|
|
--- a/tools/perf/tests/pmu.c
|
|
+++ b/tools/perf/tests/pmu.c
|
|
@@ -95,7 +95,7 @@ static char *test_format_dir_get(void)
|
|
struct test_format *format = &test_formats[i];
|
|
FILE *file;
|
|
|
|
- snprintf(name, PATH_MAX, "%s/%s", dir, format->name);
|
|
+ scnprintf(name, PATH_MAX, "%s/%s", dir, format->name);
|
|
|
|
file = fopen(name, "w");
|
|
if (!file)
|
|
diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c
|
|
index 1dd1949b0e79..1e1c37a17355 100644
|
|
--- a/tools/perf/util/annotate.c
|
|
+++ b/tools/perf/util/annotate.c
|
|
@@ -1077,7 +1077,7 @@ int symbol__annotate(struct symbol *sym, struct map *map, size_t privsize)
|
|
struct dso *dso = map->dso;
|
|
char *filename = dso__build_id_filename(dso, NULL, 0);
|
|
bool free_filename = true;
|
|
- char command[PATH_MAX * 2];
|
|
+ char *command;
|
|
FILE *file;
|
|
int err = 0;
|
|
char symfs_filename[PATH_MAX];
|
|
@@ -1192,7 +1192,7 @@ fallback:
|
|
strcpy(symfs_filename, tmp);
|
|
}
|
|
|
|
- snprintf(command, sizeof(command),
|
|
+ err = asprintf(&command,
|
|
"%s %s%s --start-address=0x%016" PRIx64
|
|
" --stop-address=0x%016" PRIx64
|
|
" -l -d %s %s -C %s 2>/dev/null|grep -v %s|expand",
|
|
@@ -1205,6 +1205,11 @@ fallback:
|
|
symbol_conf.annotate_src ? "-S" : "",
|
|
symfs_filename, filename);
|
|
|
|
+ if (err < 0) {
|
|
+ pr_err("Failure allocating memory for the command to run\n");
|
|
+ goto out_remove_tmp;
|
|
+ }
|
|
+
|
|
pr_debug("Executing: %s\n", command);
|
|
|
|
file = popen(command, "r");
|
|
@@ -1214,7 +1219,7 @@ fallback:
|
|
* If we were using debug info should retry with
|
|
* original binary.
|
|
*/
|
|
- goto out_remove_tmp;
|
|
+ goto out_free_command;
|
|
}
|
|
|
|
nline = 0;
|
|
@@ -1237,6 +1242,9 @@ fallback:
|
|
|
|
pclose(file);
|
|
|
|
+out_free_command:
|
|
+ free(command);
|
|
+
|
|
out_remove_tmp:
|
|
if (dso__needs_decompress(dso))
|
|
unlink(symfs_filename);
|
|
diff --git a/tools/perf/util/cgroup.c b/tools/perf/util/cgroup.c
|
|
index 32e12ecfe9c5..a32f0b34e3ed 100644
|
|
--- a/tools/perf/util/cgroup.c
|
|
+++ b/tools/perf/util/cgroup.c
|
|
@@ -64,7 +64,7 @@ static int open_cgroup(char *name)
|
|
if (cgroupfs_find_mountpoint(mnt, PATH_MAX + 1))
|
|
return -1;
|
|
|
|
- snprintf(path, PATH_MAX, "%s/%s", mnt, name);
|
|
+ scnprintf(path, PATH_MAX, "%s/%s", mnt, name);
|
|
|
|
fd = open(path, O_RDONLY);
|
|
if (fd == -1)
|
|
diff --git a/tools/perf/util/pager.c b/tools/perf/util/pager.c
|
|
index 53ef006a951c..b301d779c4af 100644
|
|
--- a/tools/perf/util/pager.c
|
|
+++ b/tools/perf/util/pager.c
|
|
@@ -16,10 +16,13 @@ static void pager_preexec(void)
|
|
* have real input
|
|
*/
|
|
fd_set in;
|
|
+ fd_set exception;
|
|
|
|
FD_ZERO(&in);
|
|
+ FD_ZERO(&exception);
|
|
FD_SET(0, &in);
|
|
- select(1, &in, NULL, &in, NULL);
|
|
+ FD_SET(0, &exception);
|
|
+ select(1, &in, NULL, &exception, NULL);
|
|
|
|
setenv("LESS", "FRSX", 0);
|
|
}
|
|
diff --git a/tools/perf/util/parse-events.c b/tools/perf/util/parse-events.c
|
|
index 9351738df703..849ad278dd5d 100644
|
|
--- a/tools/perf/util/parse-events.c
|
|
+++ b/tools/perf/util/parse-events.c
|
|
@@ -194,8 +194,8 @@ struct tracepoint_path *tracepoint_id_to_path(u64 config)
|
|
|
|
for_each_event(sys_dirent, evt_dir, evt_dirent) {
|
|
|
|
- snprintf(evt_path, MAXPATHLEN, "%s/%s/id", dir_path,
|
|
- evt_dirent->d_name);
|
|
+ scnprintf(evt_path, MAXPATHLEN, "%s/%s/id", dir_path,
|
|
+ evt_dirent->d_name);
|
|
fd = open(evt_path, O_RDONLY);
|
|
if (fd < 0)
|
|
continue;
|
|
diff --git a/tools/perf/util/pmu.c b/tools/perf/util/pmu.c
|
|
index 4f650ebd564a..5245fbd09106 100644
|
|
--- a/tools/perf/util/pmu.c
|
|
+++ b/tools/perf/util/pmu.c
|
|
@@ -302,7 +302,7 @@ static int pmu_aliases_parse(char *dir, struct list_head *head)
|
|
if (pmu_alias_info_file(name))
|
|
continue;
|
|
|
|
- snprintf(path, PATH_MAX, "%s/%s", dir, name);
|
|
+ scnprintf(path, PATH_MAX, "%s/%s", dir, name);
|
|
|
|
file = fopen(path, "r");
|
|
if (!file) {
|
|
diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c
|
|
index 0195b7e8c54a..4f05424096b6 100644
|
|
--- a/tools/perf/util/probe-event.c
|
|
+++ b/tools/perf/util/probe-event.c
|
|
@@ -122,7 +122,7 @@ static struct symbol *__find_kernel_function(u64 addr, struct map **mapp)
|
|
return machine__find_kernel_function(host_machine, addr, mapp, NULL);
|
|
}
|
|
|
|
-static struct ref_reloc_sym *kernel_get_ref_reloc_sym(void)
|
|
+static struct ref_reloc_sym *kernel_get_ref_reloc_sym(struct map **pmap)
|
|
{
|
|
/* kmap->ref_reloc_sym should be set if host_machine is initialized */
|
|
struct kmap *kmap;
|
|
@@ -134,6 +134,10 @@ static struct ref_reloc_sym *kernel_get_ref_reloc_sym(void)
|
|
kmap = map__kmap(map);
|
|
if (!kmap)
|
|
return NULL;
|
|
+
|
|
+ if (pmap)
|
|
+ *pmap = map;
|
|
+
|
|
return kmap->ref_reloc_sym;
|
|
}
|
|
|
|
@@ -145,7 +149,7 @@ static int kernel_get_symbol_address_by_name(const char *name, u64 *addr,
|
|
struct map *map;
|
|
|
|
/* ref_reloc_sym is just a label. Need a special fix*/
|
|
- reloc_sym = kernel_get_ref_reloc_sym();
|
|
+ reloc_sym = kernel_get_ref_reloc_sym(NULL);
|
|
if (reloc_sym && strcmp(name, reloc_sym->name) == 0)
|
|
*addr = (reloc) ? reloc_sym->addr : reloc_sym->unrelocated_addr;
|
|
else {
|
|
@@ -618,6 +622,7 @@ static int post_process_probe_trace_events(struct probe_trace_event *tevs,
|
|
bool uprobe)
|
|
{
|
|
struct ref_reloc_sym *reloc_sym;
|
|
+ struct map *map;
|
|
char *tmp;
|
|
int i, skipped = 0;
|
|
|
|
@@ -628,7 +633,7 @@ static int post_process_probe_trace_events(struct probe_trace_event *tevs,
|
|
if (module)
|
|
return add_module_to_probe_trace_events(tevs, ntevs, module);
|
|
|
|
- reloc_sym = kernel_get_ref_reloc_sym();
|
|
+ reloc_sym = kernel_get_ref_reloc_sym(&map);
|
|
if (!reloc_sym) {
|
|
pr_warning("Relocated base symbol is not found!\n");
|
|
return -EINVAL;
|
|
@@ -637,9 +642,13 @@ static int post_process_probe_trace_events(struct probe_trace_event *tevs,
|
|
for (i = 0; i < ntevs; i++) {
|
|
if (!tevs[i].point.address || tevs[i].point.retprobe)
|
|
continue;
|
|
- /* If we found a wrong one, mark it by NULL symbol */
|
|
+ /*
|
|
+ * If we found a wrong one, mark it by NULL symbol.
|
|
+ * Since addresses in debuginfo is same as objdump, we need
|
|
+ * to convert it to addresses on memory.
|
|
+ */
|
|
if (kprobe_warn_out_range(tevs[i].point.symbol,
|
|
- tevs[i].point.address)) {
|
|
+ map__objdump_2mem(map, tevs[i].point.address))) {
|
|
tmp = NULL;
|
|
skipped++;
|
|
} else {
|
|
@@ -2553,7 +2562,7 @@ static int find_probe_trace_events_from_map(struct perf_probe_event *pev,
|
|
|
|
/* Note that the symbols in the kmodule are not relocated */
|
|
if (!pev->uprobes && !pp->retprobe && !pev->target) {
|
|
- reloc_sym = kernel_get_ref_reloc_sym();
|
|
+ reloc_sym = kernel_get_ref_reloc_sym(NULL);
|
|
if (!reloc_sym) {
|
|
pr_warning("Relocated base symbol is not found!\n");
|
|
ret = -EINVAL;
|
|
diff --git a/tools/perf/util/srcline.c b/tools/perf/util/srcline.c
|
|
index b4db3f48e3b0..2853d4728ab9 100644
|
|
--- a/tools/perf/util/srcline.c
|
|
+++ b/tools/perf/util/srcline.c
|
|
@@ -86,16 +86,30 @@ static void find_address_in_section(bfd *abfd, asection *section, void *data)
|
|
bfd_vma pc, vma;
|
|
bfd_size_type size;
|
|
struct a2l_data *a2l = data;
|
|
+ flagword flags;
|
|
|
|
if (a2l->found)
|
|
return;
|
|
|
|
- if ((bfd_get_section_flags(abfd, section) & SEC_ALLOC) == 0)
|
|
+#ifdef bfd_get_section_flags
|
|
+ flags = bfd_get_section_flags(abfd, section);
|
|
+#else
|
|
+ flags = bfd_section_flags(section);
|
|
+#endif
|
|
+ if ((flags & SEC_ALLOC) == 0)
|
|
return;
|
|
|
|
pc = a2l->addr;
|
|
+#ifdef bfd_get_section_vma
|
|
vma = bfd_get_section_vma(abfd, section);
|
|
+#else
|
|
+ vma = bfd_section_vma(section);
|
|
+#endif
|
|
+#ifdef bfd_get_section_size
|
|
size = bfd_get_section_size(section);
|
|
+#else
|
|
+ size = bfd_section_size(section);
|
|
+#endif
|
|
|
|
if (pc < vma || pc >= vma + size)
|
|
return;
|