245 lines
9.3 KiB
Diff
245 lines
9.3 KiB
Diff
From b9335b9a01fc5eadeec6c50a81e68a9e9799de2d Mon Sep 17 00:00:00 2001
|
|
From: Thomas Zimmermann <tzimmermann@suse.de>
|
|
Date: Wed, 23 Sep 2020 12:21:51 +0200
|
|
Subject: [PATCH] drm/rockchip: Convert to drm_gem_object_funcs
|
|
MIME-Version: 1.0
|
|
Content-Type: text/plain; charset=UTF-8
|
|
Content-Transfer-Encoding: 8bit
|
|
|
|
GEM object functions deprecate several similar callback interfaces in
|
|
struct drm_driver. This patch replaces the per-driver callbacks with
|
|
per-instance callbacks in rockchip. The only exception is gem_prime_mmap,
|
|
which is non-trivial to convert.
|
|
|
|
v3:
|
|
* update documentation
|
|
|
|
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
|
|
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
|
|
Acked-by: Christian König <christian.koenig@amd.com>
|
|
Link: https://patchwork.freedesktop.org/patch/msgid/20200923102159.24084-15-tzimmermann@suse.de
|
|
(cherry picked from commit 0d590af3140d0f84c537a9ad252aecc780ed7aa5)
|
|
---
|
|
drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 5 -----
|
|
drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 12 +++++++++++-
|
|
2 files changed, 11 insertions(+), 6 deletions(-)
|
|
|
|
diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c
|
|
index 0f3eb392fe39..b7654f5e4225 100644
|
|
--- a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c
|
|
+++ b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c
|
|
@@ -212,15 +212,10 @@ static const struct file_operations rockchip_drm_driver_fops = {
|
|
static struct drm_driver rockchip_drm_driver = {
|
|
.driver_features = DRIVER_MODESET | DRIVER_GEM | DRIVER_ATOMIC,
|
|
.lastclose = drm_fb_helper_lastclose,
|
|
- .gem_vm_ops = &drm_gem_cma_vm_ops,
|
|
- .gem_free_object_unlocked = rockchip_gem_free_object,
|
|
.dumb_create = rockchip_gem_dumb_create,
|
|
.prime_handle_to_fd = drm_gem_prime_handle_to_fd,
|
|
.prime_fd_to_handle = drm_gem_prime_fd_to_handle,
|
|
- .gem_prime_get_sg_table = rockchip_gem_prime_get_sg_table,
|
|
.gem_prime_import_sg_table = rockchip_gem_prime_import_sg_table,
|
|
- .gem_prime_vmap = rockchip_gem_prime_vmap,
|
|
- .gem_prime_vunmap = rockchip_gem_prime_vunmap,
|
|
.gem_prime_mmap = rockchip_gem_mmap_buf,
|
|
.fops = &rockchip_drm_driver_fops,
|
|
.name = DRIVER_NAME,
|
|
diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
|
|
index 62e5d0970525..1cf4631461c9 100644
|
|
--- a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
|
|
+++ b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
|
|
@@ -295,6 +295,14 @@ static void rockchip_gem_release_object(struct rockchip_gem_object *rk_obj)
|
|
kfree(rk_obj);
|
|
}
|
|
|
|
+static const struct drm_gem_object_funcs rockchip_gem_object_funcs = {
|
|
+ .free = rockchip_gem_free_object,
|
|
+ .get_sg_table = rockchip_gem_prime_get_sg_table,
|
|
+ .vmap = rockchip_gem_prime_vmap,
|
|
+ .vunmap = rockchip_gem_prime_vunmap,
|
|
+ .vm_ops = &drm_gem_cma_vm_ops,
|
|
+};
|
|
+
|
|
static struct rockchip_gem_object *
|
|
rockchip_gem_alloc_object(struct drm_device *drm, unsigned int size)
|
|
{
|
|
@@ -309,6 +317,8 @@ static struct rockchip_gem_object *
|
|
|
|
obj = &rk_obj->base;
|
|
|
|
+ obj->funcs = &rockchip_gem_object_funcs;
|
|
+
|
|
drm_gem_object_init(drm, obj, size);
|
|
|
|
return rk_obj;
|
|
@@ -337,7 +347,7 @@ rockchip_gem_create_object(struct drm_device *drm, unsigned int size,
|
|
}
|
|
|
|
/*
|
|
- * rockchip_gem_free_object - (struct drm_driver)->gem_free_object_unlocked
|
|
+ * rockchip_gem_free_object - (struct drm_gem_object_funcs)->free
|
|
* callback function
|
|
*/
|
|
void rockchip_gem_free_object(struct drm_gem_object *obj)
|
|
|
|
From ba7e8c9f9c79119c569466b08b58a3b20aa0dca9 Mon Sep 17 00:00:00 2001
|
|
From: Thomas Zimmermann <tzimmermann@suse.de>
|
|
Date: Mon, 28 Sep 2020 10:16:43 +0200
|
|
Subject: [PATCH] drm/rockchip: Include <drm/drm_gem_cma_helper> for
|
|
drm_gem_cm_vm_ops
|
|
MIME-Version: 1.0
|
|
Content-Type: text/plain; charset=UTF-8
|
|
Content-Transfer-Encoding: 8bit
|
|
|
|
Include <drm/drm_gem_cma_helper.h> to get drm_gem_cma_vm_ops. Fallout
|
|
from the recent conversion to GEM object functions.
|
|
|
|
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
|
|
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
|
|
Reported-by: kernel test robot <lkp@intel.com>
|
|
Fixes: 0d590af3140d ("drm/rockchip: Convert to drm_gem_object_funcs")
|
|
Cc: Thomas Zimmermann <tzimmermann@suse.de>
|
|
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
|
|
Cc: Christian König <christian.koenig@amd.com>
|
|
Cc: Sandy Huang <hjc@rock-chips.com>
|
|
Cc: "Heiko Stübner" <heiko@sntech.de>
|
|
Cc: dri-devel@lists.freedesktop.org
|
|
Cc: linux-arm-kernel@lists.infradead.org
|
|
Cc: linux-rockchip@lists.infradead.org
|
|
Link: https://patchwork.freedesktop.org/patch/msgid/20200928081643.8575-1-tzimmermann@suse.de
|
|
(cherry picked from commit 8f7db83e6abf863c6a2cfddbe7086f1e3251fdbf)
|
|
---
|
|
drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 1 +
|
|
1 file changed, 1 insertion(+)
|
|
|
|
diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
|
|
index 1cf4631461c9..7d5ebb10323b 100644
|
|
--- a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
|
|
+++ b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
|
|
@@ -10,6 +10,7 @@
|
|
|
|
#include <drm/drm.h>
|
|
#include <drm/drm_gem.h>
|
|
+#include <drm/drm_gem_cma_helper.h>
|
|
#include <drm/drm_prime.h>
|
|
#include <drm/drm_vma_manager.h>
|
|
|
|
|
|
From 40175ca66971e6bde3e4c3e466616da07711271d Mon Sep 17 00:00:00 2001
|
|
From: Qinglang Miao <miaoqinglang@huawei.com>
|
|
Date: Mon, 21 Sep 2020 21:10:19 +0800
|
|
Subject: [PATCH] drm/panfrost: simplify the return expression of
|
|
cz_ih_hw_init()
|
|
|
|
Simplify the return expression.
|
|
|
|
Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com>
|
|
Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
|
|
Reviewed-by: Steven Price <steven.price@arm.com>
|
|
Signed-off-by: Steven Price <steven.price@arm.com>
|
|
Link: https://patchwork.freedesktop.org/patch/msgid/20200921131019.91558-1-miaoqinglang@huawei.com
|
|
(cherry picked from commit 3c4641d4e75618fa1b5501b9ae9c19f765d75725)
|
|
---
|
|
drivers/gpu/drm/panfrost/panfrost_device.c | 8 +-------
|
|
1 file changed, 1 insertion(+), 7 deletions(-)
|
|
|
|
diff --git a/drivers/gpu/drm/panfrost/panfrost_device.c b/drivers/gpu/drm/panfrost/panfrost_device.c
|
|
index e6896733838a..ea8d31863c50 100644
|
|
--- a/drivers/gpu/drm/panfrost/panfrost_device.c
|
|
+++ b/drivers/gpu/drm/panfrost/panfrost_device.c
|
|
@@ -18,19 +18,13 @@
|
|
|
|
static int panfrost_reset_init(struct panfrost_device *pfdev)
|
|
{
|
|
- int err;
|
|
-
|
|
pfdev->rstc = devm_reset_control_array_get(pfdev->dev, false, true);
|
|
if (IS_ERR(pfdev->rstc)) {
|
|
dev_err(pfdev->dev, "get reset failed %ld\n", PTR_ERR(pfdev->rstc));
|
|
return PTR_ERR(pfdev->rstc);
|
|
}
|
|
|
|
- err = reset_control_deassert(pfdev->rstc);
|
|
- if (err)
|
|
- return err;
|
|
-
|
|
- return 0;
|
|
+ return reset_control_deassert(pfdev->rstc);
|
|
}
|
|
|
|
static void panfrost_reset_fini(struct panfrost_device *pfdev)
|
|
|
|
From 7e4d1ac491e3ac8b8b03d74129ef9521cdf479ef Mon Sep 17 00:00:00 2001
|
|
From: Qinglang Miao <miaoqinglang@huawei.com>
|
|
Date: Mon, 21 Sep 2020 21:10:21 +0800
|
|
Subject: [PATCH] drm/panfrost: simplify the return expression of
|
|
panfrost_devfreq_target()
|
|
|
|
Simplify the return expression.
|
|
|
|
Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com>
|
|
Reviewed-by: Steven Price <steven.price@arm.com>
|
|
Signed-off-by: Steven Price <steven.price@arm.com>
|
|
Link: https://patchwork.freedesktop.org/patch/msgid/20200921131021.91604-1-miaoqinglang@huawei.com
|
|
(cherry picked from commit 0c5036590bde1407a6250ea027e836815353820f)
|
|
---
|
|
drivers/gpu/drm/panfrost/panfrost_devfreq.c | 7 +------
|
|
1 file changed, 1 insertion(+), 6 deletions(-)
|
|
|
|
diff --git a/drivers/gpu/drm/panfrost/panfrost_devfreq.c b/drivers/gpu/drm/panfrost/panfrost_devfreq.c
|
|
index 8ab025d0035f..913eaa6d0bc6 100644
|
|
--- a/drivers/gpu/drm/panfrost/panfrost_devfreq.c
|
|
+++ b/drivers/gpu/drm/panfrost/panfrost_devfreq.c
|
|
@@ -29,18 +29,13 @@ static int panfrost_devfreq_target(struct device *dev, unsigned long *freq,
|
|
u32 flags)
|
|
{
|
|
struct dev_pm_opp *opp;
|
|
- int err;
|
|
|
|
opp = devfreq_recommended_opp(dev, freq, flags);
|
|
if (IS_ERR(opp))
|
|
return PTR_ERR(opp);
|
|
dev_pm_opp_put(opp);
|
|
|
|
- err = dev_pm_opp_set_rate(dev, *freq);
|
|
- if (err)
|
|
- return err;
|
|
-
|
|
- return 0;
|
|
+ return dev_pm_opp_set_rate(dev, *freq);
|
|
}
|
|
|
|
static void panfrost_devfreq_reset(struct panfrost_devfreq *pfdevfreq)
|
|
|
|
From 7efe8c0d9576db34e4d5427d5a939a20f4afe96f Mon Sep 17 00:00:00 2001
|
|
From: Rikard Falkeborn <rikard.falkeborn@gmail.com>
|
|
Date: Sun, 4 Oct 2020 22:06:53 +0200
|
|
Subject: [PATCH] drm: bridge: dw-hdmi: Constify dw_hdmi_i2s_ops
|
|
|
|
The only usage of dw_hdmi_i2s_ops is to assign its address to the ops
|
|
field in the hdmi_codec_pdata struct, which is a const pointer. Make it
|
|
const to allow the compiler to put it in read-only memory.
|
|
|
|
Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>
|
|
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
|
|
Link: https://patchwork.freedesktop.org/patch/msgid/20201004200653.14702-1-rikard.falkeborn@gmail.com
|
|
(cherry picked from commit f3d52908f6baffc21ba45058103d0226ca5cb073)
|
|
---
|
|
drivers/gpu/drm/bridge/synopsys/dw-hdmi-i2s-audio.c | 2 +-
|
|
1 file changed, 1 insertion(+), 1 deletion(-)
|
|
|
|
diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-i2s-audio.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-i2s-audio.c
|
|
index 9fef6413741d..feb04f127b55 100644
|
|
--- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-i2s-audio.c
|
|
+++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-i2s-audio.c
|
|
@@ -170,7 +170,7 @@ static int dw_hdmi_i2s_hook_plugged_cb(struct device *dev, void *data,
|
|
return dw_hdmi_set_plugged_cb(hdmi, fn, codec_dev);
|
|
}
|
|
|
|
-static struct hdmi_codec_ops dw_hdmi_i2s_ops = {
|
|
+static const struct hdmi_codec_ops dw_hdmi_i2s_ops = {
|
|
.hw_params = dw_hdmi_i2s_hw_params,
|
|
.audio_startup = dw_hdmi_i2s_audio_startup,
|
|
.audio_shutdown = dw_hdmi_i2s_audio_shutdown,
|
|
|